#3359 fix: try to mitigate Nextcloud sync errors

Signed-off-by: Patrizio Bekerle <patrizio@bekerle.com>

Author: pbek

CHANGELOG.md

@@ -2,6 +2,9 @@
 
 ## 25.9.2
 
+- Try to mitigate Nextcloud sync errors by not triggering an expiration of
+  trashed notes periodically, rather we want to do it after the note folder
+  was reloaded (for [#3359](https://github.com/pbek/QOwnNotes/issues/3359))
 - The save button in the **Nextcloud Deck dialog** will now only insert a link
   into the current note for new cards (for [#3357](https://github.com/pbek/QOwnNotes/issues/3357))
 - The Groq AI model list was updated (for [#3365](https://github.com/pbek/QOwnNotes/issues/3365), thank you, @Weej1)

src/mainwindow.cpp

@@ -1073,6 +1073,11 @@ void MainWindow::buildNotesIndexAndLoadNoteDirectoryList(bool forceBuild, bool f
 
     if (wasBuilt || forceLoad) {
         loadNoteDirectoryList();
+
+        // Expire trashed items
+        // It is safer to do that here than in MainWindow::frequentPeriodicChecker(), to avoid
+        // sync errors after resuming from suspend
+        TrashItem::expireItems();
     }
 
     if (wasBuilt && reloadTabs) {
@@ -3139,9 +3144,6 @@ void MainWindow::frequentPeriodicChecker() {
     } else if (lastUpdateCheck.addSecs(3600) <= QDateTime::currentDateTime()) {
         // check for updates every 1h
         updateService->checkForUpdates(UpdateService::Periodic);
-
-        // expire trashed items
-        TrashItem::expireItems();
     }
 }