Skip to content

Commit b937706

Browse files
committed
fix: update Viewport Size toggle to better handle async-loaded ishControl data + prevent rendering errors
1 parent d3660b7 commit b937706

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

packages/uikit-workshop/src/scripts/lit-components/pl-viewport-size-list/pl-viewport-size-list.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ class ViewportSizes extends BaseComponent {
5454
super.connectedCallback && super.connectedCallback();
5555
styles.use();
5656
const state = store.getState();
57-
const { ishControlsHide } = window.ishControls;
57+
const { ishControlsHide } = window?.ishControls;
5858
this.ishControlsHide = ishControlsHide;
5959

6060
// Remove EventListener or they will be added multiple times when reloading in serve mode
@@ -301,7 +301,7 @@ class ViewportSizes extends BaseComponent {
301301
render() {
302302
return (
303303
<ul class="pl-c-size-list">
304-
{!this.ishControlsHide.s && (
304+
{!this.ishControlsHide?.s && (
305305
<li class="pl-c-size-list__item">
306306
<Tooltip
307307
placement="top"
@@ -328,7 +328,7 @@ class ViewportSizes extends BaseComponent {
328328
</Tooltip>
329329
</li>
330330
)}
331-
{!this.ishControlsHide.m && (
331+
{!this.ishControlsHide?.m && (
332332
<li class="pl-c-size-list__item">
333333
<Tooltip
334334
placement="top"
@@ -355,7 +355,7 @@ class ViewportSizes extends BaseComponent {
355355
</Tooltip>
356356
</li>
357357
)}
358-
{!this.ishControlsHide.l && (
358+
{!this.ishControlsHide?.l && (
359359
<li class="pl-c-size-list__item">
360360
<Tooltip
361361
placement="top"
@@ -382,7 +382,7 @@ class ViewportSizes extends BaseComponent {
382382
</Tooltip>
383383
</li>
384384
)}
385-
{!this.ishControlsHide.full && (
385+
{!this.ishControlsHide?.full && (
386386
<li class="pl-c-size-list__item">
387387
<Tooltip
388388
placement="top"
@@ -409,7 +409,7 @@ class ViewportSizes extends BaseComponent {
409409
</Tooltip>
410410
</li>
411411
)}
412-
{!this.ishControlsHide.random && (
412+
{!this.ishControlsHide?.random && (
413413
<li class="pl-c-size-list__item">
414414
<Tooltip
415415
placement="top"
@@ -436,7 +436,7 @@ class ViewportSizes extends BaseComponent {
436436
</Tooltip>
437437
</li>
438438
)}
439-
{!this.ishControlsHide.disco && (
439+
{!this.ishControlsHide?.disco && (
440440
<li class="pl-c-size-list__item">
441441
<Tooltip
442442
placement="top"
@@ -463,7 +463,7 @@ class ViewportSizes extends BaseComponent {
463463
</Tooltip>
464464
</li>
465465
)}
466-
{!this.ishControlsHide.hay && (
466+
{!this.ishControlsHide?.hay && (
467467
<li class="pl-c-size-list__item">
468468
<Tooltip
469469
placement="top"

0 commit comments

Comments
 (0)