Skip to content

Commit 7dd18f9

Browse files
#1143: Fix naming of view-all links
1 parent fec2492 commit 7dd18f9

File tree

4 files changed

+9
-6
lines changed

4 files changed

+9
-6
lines changed

packages/core/src/lib/ui_builder.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ const ui_builder = function() {
175175
*/
176176
function addPatternType(patternlab, pattern) {
177177
patternlab.patternTypes.push({
178-
patternTypeLC: pattern.patternGroup.toLowerCase(),
178+
patternTypeLC: _.kebabCase(pattern.patternGroup),
179179
patternTypeUC: _.startCase(pattern.patternGroup),
180180
patternType: pattern.patternType,
181181
patternTypeDash: pattern.patternGroup, //todo verify
@@ -234,7 +234,7 @@ const ui_builder = function() {
234234
*/
235235
function addPatternSubType(patternlab, pattern) {
236236
const newSubType = {
237-
patternSubtypeLC: pattern.patternSubGroup.toLowerCase(),
237+
patternSubtypeLC: _.kebabCase(pattern.patternSubGroup),
238238
patternSubtypeUC: _.startCase(pattern.patternSubGroup),
239239
patternSubtype: pattern.patternSubType,
240240
patternSubtypeDash: pattern.patternSubGroup, //todo verify

packages/uikit-workshop/src/scripts/components/pl-nav/pl-nav.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -276,6 +276,7 @@ class Nav extends BaseComponent {
276276
<NavList
277277
elem={this.elem}
278278
category={patternSubtype.patternSubtypeLC}
279+
categoryName={patternSubtype.patternSubtypeUC}
279280
>
280281
{patternSubtype.patternSubtypeItems}
281282
</NavList>

packages/uikit-workshop/src/scripts/components/pl-nav/src/NavLink.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export const NavLink = props => {
1616
data-patternpartial={props.item.patternPartial}
1717
>
1818
{props.item.isDocPattern && props.category
19-
? `${props.category}`
19+
? `${props.categoryName}`
2020
: props.item.patternName}
2121
{props.item.patternState && (
2222
<PatternState variant={props.item.patternState} />

packages/uikit-workshop/src/scripts/components/pl-nav/src/NavList.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { NavLink } from './NavLink';
44
import { NavItem } from './NavItem';
55

66
export const NavList = props => {
7-
const { children, category, elem } = props;
7+
const { children, category, categoryName, elem } = props;
88
const reorderedChildren = [];
99

1010
const nonViewAllItems = elem.noViewAll
@@ -25,6 +25,7 @@ export const NavList = props => {
2525
<div class="pl-c-nav__link--overview-wrapper">
2626
<NavLink
2727
category={category}
28+
categoryName={categoryName}
2829
item={patternSubtypeItem}
2930
elem={elem}
3031
/>
@@ -34,14 +35,14 @@ export const NavList = props => {
3435
aria-controls={category}
3536
onClick={elem.toggleSpecialNavPanel}
3637
>
37-
{category}
38+
{categoryName}
3839
</NavToggle>
3940
)}
4041
</div>
4142
))
4243
) : (
4344
<Button aria-controls={category} onClick={elem.toggleNavPanel}>
44-
{category}
45+
{categoryName}
4546
</Button>
4647
)}
4748

@@ -55,6 +56,7 @@ export const NavList = props => {
5556
<NavItem>
5657
<NavLink
5758
category={category}
59+
categoryName={categoryName}
5860
item={patternSubtypeItem}
5961
elem={elem}
6062
/>

0 commit comments

Comments
 (0)