Skip to content

Commit 57ff4b0

Browse files
authored
Merge branch 'dev' into fix-uikitworkshop-absolutely-positioned-pattern-parts-at-the-vertical-end-of-the-page-would-get-cropped
2 parents 2a7efee + e164127 commit 57ff4b0

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

.github/CONTRIBUTING.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ nvm use <<version>>
1818
The best way to make changes to the Pattern Lab Node core and test them is through an edition.
1919
2020
* Fork this repository on Github.
21-
* `npm install && npm run bootstrap`
21+
* `yarn install && yarn run bootstrap`
2222
* Create a new branch in your fork and push your changes in that fork.
2323
* `cd packages/edition-node`
2424
* Test your changes with the edition's api
@@ -28,7 +28,7 @@ The best way to make changes to the Pattern Lab Node core and test them is throu
2828
To ensure that developers can bootstrap the repo from a fresh clone, do this in your working copy:
2929
3030
```sh
31-
git reset --hard && git clean -dfx && npm install && npm run bootstrap
31+
git reset --hard && git clean -dfx && yarn install && yarn run bootstrap
3232
```
3333
3434
This ensures that any changes you've made will still result in a clean and functional developer experience. **Note**: be sure you've committed any outstanding work before doing this -- it will blow away whatever's still outstanding, including anything staged but not commited.
@@ -37,6 +37,7 @@ This ensures that any changes you've made will still result in a clean and funct
3737
3838
* _ALWAYS_ submit pull requests against the [dev branch](https://github.com/pattern-lab/patternlab-node/tree/dev). If this does not occur, I will first, try to redirect you gently, second, attempt to redirect the target branch myself, thirdly, port over your contribution manually if time allows, and/or lastly, close your pull request. If you have a major feature to stabilize over time, talk to @bmuenzenmeyer via an issue about making a dedicated `feature-branch`
3939
* Keep your pull requests concise and limited to **ONE** substantive change at a time. This makes reviewing and testing so much easier.
40+
* If it takes you considerable time to finish your work, submit a [draft pull request](https://github.blog/2019-02-14-introducing-draft-pull-requests/). This is Github's way to indicate work in progress but allows for feedback.
4041
* Commits should reference the issue you are adressing. For any Pull Request that you send, use the template provided.
4142
* Commits are best formatted using the [conventional commits pattern](https://conventionalcommits.org/).
4243
* If you can, add some unit tests using the existing patterns in the `.packages/core/test` directory

packages/docs/src/support.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,4 @@ title: Pattern Lab Support
99

1010
## Gitter
1111

12-
You can head over to [Pattern Lab's Gitter](https://gitter.im/pattern-lab/home) to chat with the Pattern Lab community. This is a great place to talk shop, ask quesitons, and get (and give!) help.
12+
You can head over to [Pattern Lab's Gitter](https://gitter.im/pattern-lab/home) to chat with the Pattern Lab community. This is a great place to talk shop, ask questions, and get (and give!) help.

0 commit comments

Comments
 (0)