Skip to content

Commit 3f33ce5

Browse files
mfranzkeMaximilian
andauthored
fix(annotations): displaying annotation tooltips correctly (#1406)
* chore(docs): some typos missed to replace mustache initially and incorrect handlebars two times (both in package name and URL) * Revert "Merge pull request #2 from pattern-lab/dev" This reverts commit 7812878, reversing changes made to 26db979. * Revert "Merge pull request #1 from pattern-lab/dev" This reverts commit 26db979, reversing changes made to fc90750. * Revert "chore(docs): some typos" This reverts commit 271dc8d. * chore: some reformatting * chore: formatting * chore: formatting This reverts commit 271dc8d. * chore: formatting * refactor: let's hide elements the modern way with the hidden attribute * refactor: extracting annotations inside modal styles * refactor: we won't need this as a generated CSS file * Revert "Merge branch 'dev' into fix/annotations-tooltip-rendering" This reverts commit 2c715ae, reversing changes made to 5effb4f. * refactor: adding some sample content for the annotations and corrected the current approach to provide annotations JSON * refactor: regenerated those files Co-authored-by: Maximilian <mfr@nzke.net>
1 parent a3ec132 commit 3f33ce5

File tree

13 files changed

+1333
-696
lines changed

13 files changed

+1333
-696
lines changed
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
var comments = {
2+
"comments": []
3+
};

packages/development-edition-engine-handlebars/source/_annotations/annotations.json

Lines changed: 0 additions & 3 deletions
This file was deleted.
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
var comments = {
2+
"comments" : [
3+
{
4+
"el": ".c-header",
5+
"title" : "Masthead",
6+
"comment": "The main header of the site doesn't take up too much screen real estate in order to keep the focus on the core content."
7+
},
8+
{
9+
"el": ".c-logo",
10+
"title": "Logo",
11+
"comment": "The logo isn't an image but regular text, which ensures that the logo displays crisply even on high resolution displays."
12+
}
13+
]
14+
};

0 commit comments

Comments
 (0)