Clean-up some clippy and rust warnings (#578)

Author: jpschorr

partiql-ast/src/ast/mod.rs

@@ -417,7 +417,7 @@ pub enum Expr {
     Call(AstNode<Call>),
     CallAgg(AstNode<CallAgg>),
     /// <expr> MATCH <graph_pattern>
-    GraphMatch(AstNode<GraphMatch>),
+    GraphMatch(Box<AstNode<GraphMatch>>),
 
     /// Query, e.g. `UNION` | `EXCEPT` | `INTERSECT` | `SELECT` and their parts.
     Query(AstNode<Query>),

partiql-eval/src/plan.rs

@@ -498,8 +498,8 @@ impl<'c> EvaluatorPlanner<'c> {
 
                 ("pattern expr", expr)
             }
-            ValueExpr::GraphMatch(GraphMatchExpr { value, pattern }) => {
-                //
+            ValueExpr::GraphMatch(graph_match) => {
+                let GraphMatchExpr { value, pattern } = graph_match.as_ref();
                 let args = plan_args(&[value]);
                 let expr = match self.plan_graph_plan::<{ STRICT }>(pattern) {
                     Ok(pattern) => EvalGraphMatch::new(pattern).bind::<{ STRICT }>(args),

partiql-logical-planner/src/lower.rs

@@ -1986,10 +1986,10 @@ impl<'ast> Visitor<'ast> for AstToLogical<'_> {
                 );
                 let graph_reference = Box::new(graph_reference.unwrap());
 
-                self.push_vexpr(ValueExpr::GraphMatch(GraphMatchExpr {
+                self.push_vexpr(ValueExpr::GraphMatch(Box::new(GraphMatchExpr {
                     value: graph_reference,
                     pattern,
-                }));
+                })));
                 Traverse::Continue
             }
             Err(e) => {

partiql-logical/src/lib.rs

@@ -473,7 +473,7 @@ pub enum ValueExpr {
     NullIfExpr(NullIfExpr),
     CoalesceExpr(CoalesceExpr),
     Call(CallExpr),
-    GraphMatch(GraphMatchExpr),
+    GraphMatch(Box<GraphMatchExpr>),
 }
 
 /// Represents a `PartiQL` literal value.

partiql-parser/src/parse/partiql.lalrpop

@@ -358,7 +358,7 @@ ParenGraphMatch: ast::Expr = {
 
 GraphMatch: ast::Expr = {
     <lo:@L> <expr:ExprQuery> "MATCH" <pattern:GraphPattern> <shape:GraphTableShape> <hi:@R>
-        => ast::Expr::GraphMatch(state.node(ast::GraphMatch{expr, pattern, shape}, lo..hi)),
+        => ast::Expr::GraphMatch(Box::new(state.node(ast::GraphMatch{expr, pattern, shape}, lo..hi))),
 }
 
 GraphTableShape: ast::GraphTableShape = {

partiql-value/src/value.rs

@@ -280,7 +280,6 @@ impl Datum<Value> for Value {
     }
 
     #[inline]
-    #[must_use]
     fn is_sequence(&self) -> bool {
         match self {
             Value::List(_) => true,
@@ -291,7 +290,6 @@ impl Datum<Value> for Value {
     }
 
     #[inline]
-    #[must_use]
     fn is_ordered(&self) -> bool {
         match self {
             Value::List(_) => true,