Skip to content

Commit 842a75d

Browse files
authored
ci: adds --workspace to cargo fmt and fixes conformance commenting (#164)
Ran `cargo fmt --all` to cleanup minor style issues. Ignores workflow failures for conformance PR commenting if it fails (which can happen from forks).
1 parent 6c18fb5 commit 842a75d

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

.github/workflows/ci_build_test.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ jobs:
5555
uses: actions-rs/cargo@v1
5656
with:
5757
command: fmt
58-
args: --verbose -- --check
58+
args: --verbose --all -- --check
5959
# `clippy-check` will run `cargo clippy` on new pull requests. Due to a limitation in GitHub
6060
# permissions, the behavior of the Action is different depending on the source of the PR. If the
6161
# PR comes from the partiql-lang-rust project itself, any suggestions will be added to the PR as comments.
@@ -171,13 +171,15 @@ jobs:
171171
# Find comment w/ conformance comparison if previous comment published
172172
- name: Find Comment
173173
uses: peter-evans/find-comment@v2
174+
continue-on-error: true
174175
id: fc
175176
with:
176177
issue-number: ${{ github.event.pull_request.number }}
177178
comment-author: 'github-actions[bot]'
178179
body-includes: Conformance
179180
# Convert the markdown comparison report to a readable form for GitHub PR comments
180181
- id: get-comment-body
182+
continue-on-error: true
181183
run: |
182184
body="$(cat ./cts-comparison-report.md)"
183185
body="${body//'%'/'%25'}"
@@ -186,6 +188,7 @@ jobs:
186188
echo "::set-output name=body::$body"
187189
# Create or update (if previous comment exists) with markdown version of comparison report
188190
- name: Create or update comment
191+
continue-on-error: true
189192
uses: peter-evans/create-or-update-comment@v2
190193
with:
191194
comment-id: ${{ steps.fc.outputs.comment-id }}

partiql-conformance-tests/src/bin/generate_comparison_report.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ struct CTSReport {
1111
commit_hash: String,
1212
passing: Vec<String>,
1313
failing: Vec<String>,
14-
ignored: Vec<String>
14+
ignored: Vec<String>,
1515
}
1616

1717
/// Compares two conformance reports generated from [`generate_cts_report`], generating a comparison

0 commit comments

Comments
 (0)