Skip to content

Commit 735aca1

Browse files
authored
Make usage of serde optional behind feature flag (#155)
1 parent fb15fbd commit 735aca1

File tree

16 files changed

+307
-140
lines changed

16 files changed

+307
-140
lines changed

.github/workflows/ci_build_test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ jobs:
112112
continue-on-error: true
113113
run: cargo test --verbose --package partiql-conformance-tests --features "conformance_test" -- -Z unstable-options --format json > cargo_test_results.json
114114
# Create a conformance report from the `cargo test` json file
115-
- run: ./target/debug/generate_cts_report cargo_test_results.json ${GITHUB_SHA} cts_report.json
115+
- run: cargo run --features report_tool --bin generate_cts_report cargo_test_results.json ${GITHUB_SHA} cts_report.json
116116
# Upload conformance report for comparison with future runs
117117
- name: Upload cts_report.json
118118
uses: actions/upload-artifact@v3
@@ -164,7 +164,7 @@ jobs:
164164
if: ${{ steps.download-report.outcome == 'failure' }}
165165
run: mkdir -p artifact && cp -r ./partiql-conformance-tests/backup_conformance_report.json ./artifact/cts_report.json
166166
# Run conformance report comparison. Generates cts-comparison-report.md
167-
- run: ./target/debug/generate_comparison_report ./artifact/cts_report.json cts_report.json cts-comparison-report.md
167+
- run: cargo run --features report_tool --bin generate_comparison_report ./artifact/cts_report.json cts_report.json cts-comparison-report.md
168168
# Print conformance report to GitHub actions workflow summary page
169169
- name: print markdown in run
170170
run: cat cts-comparison-report.md >> $GITHUB_STEP_SUMMARY

.github/workflows/coverage.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
with:
2424
profile: minimal
2525
# nightly can be very volatile--pin this to a version we know works well...
26-
toolchain: nightly-2022-01-10
26+
toolchain: nightly-2022-06-11
2727
override: true
2828
- name: Cargo Test
2929
uses: actions-rs/cargo@v1

Cargo.toml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,11 @@ members = [
99
"partiql-eval",
1010
"partiql-irgen",
1111
"partiql-parser",
12-
"partiql-playground",
1312
"partiql-rewriter",
13+
]
14+
15+
exclude = [
16+
"partiql-playground",
1417
"partiql-cli"
1518
]
19+

partiql-ast/Cargo.toml

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,20 @@ path = "src/lib.rs"
2424
partiql-source-map = { path = "../partiql-source-map" }
2525

2626
derive_builder = "~0.11.1"
27-
rust_decimal = "~1.22.0"
28-
serde = { version = "~1.0.137", features = ["derive"] }
27+
rust_decimal = { version = "1.25.0", default-features = false, features = ["std"] }
28+
29+
serde = { version = "1.*", features = ["derive"], optional = true }
30+
2931

3032
[dev-dependencies]
3133

34+
35+
[features]
36+
default = []
37+
serde = [
38+
"dep:serde",
39+
"partiql-source-map/serde",
40+
"rust_decimal/serde-with-str",
41+
"rust_decimal/serde"
42+
]
43+

0 commit comments

Comments
 (0)