Skip to content

Commit 4b3586b

Browse files
authored
build: Release beta (#1589)
2 parents 0bb143c + 75dc899 commit 4b3586b

File tree

7 files changed

+99
-69
lines changed

7 files changed

+99
-69
lines changed

changelogs/CHANGELOG_alpha.md

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,17 @@
1+
# [3.5.0-alpha.8](https://github.com/parse-community/Parse-SDK-JS/compare/3.5.0-alpha.7...3.5.0-alpha.8) (2022-11-03)
2+
3+
4+
### Bug Fixes
5+
6+
* File upload fails when uploading base64 data ([#1578](https://github.com/parse-community/Parse-SDK-JS/issues/1578)) ([03ee3ff](https://github.com/parse-community/Parse-SDK-JS/commit/03ee3ffd3e4798f9dd958ddc24b9f774cb875507))
7+
8+
# [3.5.0-alpha.7](https://github.com/parse-community/Parse-SDK-JS/compare/3.5.0-alpha.6...3.5.0-alpha.7) (2022-11-01)
9+
10+
11+
### Bug Fixes
12+
13+
* React Native build does not maintain arrow functions and causes error with AsyncStorage ([#1587](https://github.com/parse-community/Parse-SDK-JS/issues/1587)) ([8aeaa4f](https://github.com/parse-community/Parse-SDK-JS/commit/8aeaa4f51e01f5763c497b5e86dca73835e2144b))
14+
115
# [3.5.0-alpha.6](https://github.com/parse-community/Parse-SDK-JS/compare/3.5.0-alpha.5...3.5.0-alpha.6) (2022-10-13)
216

317

integration/test/ParseFileTest.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ describe('Parse.File', () => {
6464
assert.equal(data, 'ParseA==');
6565
});
6666

67-
it('can get file data from base64', async () => {
67+
it('can get file data from base64 (saved)', async () => {
6868
const file = new Parse.File('parse-server-logo', { base64: 'ParseA==' });
6969
await file.save();
7070
let data = await file.getData();
@@ -76,6 +76,12 @@ describe('Parse.File', () => {
7676
assert.equal(data, 'ParseA==');
7777
});
7878

79+
it('can get file data from base64 (unsaved)', async () => {
80+
const file = new Parse.File('parse-server-logo', { base64: 'ParseA==' });
81+
const data = await file.getData();
82+
assert.equal(data, 'ParseA==');
83+
});
84+
7985
it('can get file data from full base64', async () => {
8086
const file = new Parse.File('parse-server-logo', {
8187
base64: 'data:image/jpeg;base64,ParseA==',

package-lock.json

Lines changed: 54 additions & 54 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "parse",
3-
"version": "3.5.0",
3+
"version": "3.5.0-alpha.8",
44
"description": "The Parse JavaScript SDK",
55
"homepage": "https://parseplatform.org/",
66
"keywords": [

src/ParseFile.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,10 @@ class ParseFile {
137137
} else if (data && typeof data.base64 === 'string') {
138138
const base64 = data.base64.split(',').slice(-1)[0];
139139
const dataType =
140-
specifiedType || data.base64.split(';').slice(0, 1)[0].split(':').slice(1, 2)[0] || 'text/plain';
140+
specifiedType ||
141+
data.base64.split(';').slice(0, 1)[0].split(':').slice(1, 2)[0] ||
142+
'text/plain';
143+
this._data = base64;
141144
this._source = {
142145
format: 'base64',
143146
base64,

src/StorageController.react-native.js

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -9,19 +9,14 @@
99
* @flow
1010
* @private
1111
*/
12-
1312
import CoreManager from './CoreManager';
1413

1514
const StorageController = {
1615
async: 1,
1716

18-
getAsyncStorage(): any {
19-
return CoreManager.getAsyncStorage();
20-
},
21-
2217
getItemAsync(path: string): Promise {
2318
return new Promise((resolve, reject) => {
24-
this.getAsyncStorage().getItem(path, function (err, value) {
19+
CoreManager.getAsyncStorage().getItem(path, (err, value) => {
2520
if (err) {
2621
reject(err);
2722
} else {
@@ -33,7 +28,7 @@ const StorageController = {
3328

3429
setItemAsync(path: string, value: string): Promise {
3530
return new Promise((resolve, reject) => {
36-
this.getAsyncStorage().setItem(path, value, function (err, value) {
31+
CoreManager.getAsyncStorage().setItem(path, value, (err, value) => {
3732
if (err) {
3833
reject(err);
3934
} else {
@@ -45,7 +40,7 @@ const StorageController = {
4540

4641
removeItemAsync(path: string): Promise {
4742
return new Promise((resolve, reject) => {
48-
this.getAsyncStorage().removeItem(path, function (err) {
43+
CoreManager.getAsyncStorage().removeItem(path, (err) => {
4944
if (err) {
5045
reject(err);
5146
} else {
@@ -57,7 +52,7 @@ const StorageController = {
5752

5853
getAllKeysAsync(): Promise {
5954
return new Promise((resolve, reject) => {
60-
this.getAsyncStorage().getAllKeys(function (err, keys) {
55+
CoreManager.getAsyncStorage().getAllKeys((err, keys) => {
6156
if (err) {
6257
reject(err);
6358
} else {
@@ -69,7 +64,7 @@ const StorageController = {
6964

7065
multiGet(keys: Array<string>): Promise<Array<Array<string>>> {
7166
return new Promise((resolve, reject) => {
72-
this.getAsyncStorage().multiGet(keys, function (err, result) {
67+
CoreManager.getAsyncStorage().multiGet(keys, (err, result) => {
7368
if (err) {
7469
reject(err);
7570
} else {
@@ -81,7 +76,7 @@ const StorageController = {
8176

8277
multiRemove(keys: Array<string>): Promise {
8378
return new Promise((resolve, reject) => {
84-
this.getAsyncStorage().multiRemove(keys, function (err) {
79+
CoreManager.getAsyncStorage().multiRemove(keys, (err) => {
8580
if (err) {
8681
reject(err);
8782
} else {
@@ -92,7 +87,7 @@ const StorageController = {
9287
},
9388

9489
clear() {
95-
return this.getAsyncStorage().clear();
90+
return CoreManager.getAsyncStorage().clear();
9691
},
9792
};
9893

0 commit comments

Comments
 (0)