Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Avoid including bin/node/cli/src/cli.rs in build.rs #14806

@zdave-parity

Description

@zdave-parity

bin/node/cli/src/cli.rs looks like a regular module. But if you for example try to reference a sibling module from it, the compiler will confusingly tell you that this sibling module can't be found. This is because as well as being built as a regular module, cli.rs is also included in build.rs. AFAICT this is to generate shell completions at build time. It seems like this could be achieved without using include!. The simplest option might be to have a separate crate just for generating shell completions. This could pull in cli.rs via a crate dependency.

Metadata

Metadata

Assignees

No one assigned

    Labels

    J2-unconfirmedIssue might be valid, but it’s not yet known.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions