Skip to content

Commit 7b89eb4

Browse files
committed
remove profile and enforce global release property for java
Signed-off-by: Sam Spycher <samspycher@users.noreply.github.com>
1 parent 812c2ab commit 7b89eb4

File tree

7 files changed

+12
-44
lines changed

7 files changed

+12
-44
lines changed

parsec-client-java/pom.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@
1111
<artifactId>parsec-client-java</artifactId>
1212
<properties>
1313
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
14-
<maven.compiler.source>1.8</maven.compiler.source>
15-
<maven.compiler.target>1.8</maven.compiler.target>
1614
</properties>
1715
<dependencies>
1816
<dependency>

parsec-interface-java/pom.xml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<project xmlns="http://maven.apache.org/POM/4.0.0"
3-
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
4-
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
3+
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
54
<modelVersion>4.0.0</modelVersion>
65

76
<parent>
@@ -12,8 +11,6 @@
1211
<artifactId>parsec-interface-java</artifactId>
1312
<properties>
1413
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
15-
<maven.compiler.source>1.8</maven.compiler.source>
16-
<maven.compiler.target>1.8</maven.compiler.target>
1714
</properties>
1815

1916
<dependencies>

parsec-jca-java-test/pom.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@
1010
<artifactId>parsec-jca-java-test</artifactId>
1111
<properties>
1212
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
13-
<maven.compiler.source>1.8</maven.compiler.source>
14-
<maven.compiler.target>1.8</maven.compiler.target>
1513
</properties>
1614

1715
<dependencies>

parsec-jca-java/src/main/java/org/parallaxsecond/parsec/jce/provider/ParsecPublicKey.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
import lombok.Builder;
44
import lombok.Value;
5-
import sun.reflect.generics.reflectiveObjects.NotImplementedException;
65

76
import java.security.PublicKey;
87

@@ -15,13 +14,14 @@ static ParsecPublicKey.ParsecPublicKeyImpl.ParsecPublicKeyImplBuilder builder()
1514

1615
@Value
1716
@Builder
18-
class ParsecPublicKeyImpl implements ParsecPublicKey{
17+
class ParsecPublicKeyImpl implements ParsecPublicKey {
1918
String parsecName;
2019
String algorithm;
2120
String format;
21+
2222
@Override
2323
public byte[] getEncoded() {
24-
throw new NotImplementedException();
24+
throw new UnsupportedOperationException("Not implemented");
2525
}
2626
}
2727
}

parsec-protobuf-java/pom.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@
1414
<protoc.version>3.18.0</protoc.version>
1515
<protobuf.version>3.19.6</protobuf.version>
1616
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
17-
<maven.compiler.source>1.8</maven.compiler.source>
18-
<maven.compiler.target>1.8</maven.compiler.target>
1917
</properties>
2018

2119
<dependencies>

parsec-testcontainers/pom.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,6 @@
2828
</dependencies>
2929
<properties>
3030
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
31-
<maven.compiler.source>1.8</maven.compiler.source>
32-
<maven.compiler.target>1.8</maven.compiler.target>
3331
<containers.skip>false</containers.skip>
3432
</properties>
3533
<build>

pom.xml

Lines changed: 8 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,14 @@
88
<version>1.0.0-SNAPSHOT</version>
99
<properties>
1010
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
11-
<maven.compiler.source>1.8</maven.compiler.source>
12-
<maven.compiler.target>1.8</maven.compiler.target>
1311
<logback.version>1.3.15</logback.version>
1412
<lombok.version>1.18.36</lombok.version>
1513
<junit.jupiter.version>5.12.1</junit.jupiter.version>
1614
<slf4j.version>2.0.16</slf4j.version>
1715
<jpms.args></jpms.args>
16+
<!-- Since compiler plugin version 3.13.0 you can use the release property also on JDK 8.
17+
The compiler plugin will convert it to source and target automatically. -->
18+
<maven.compiler.release>8</maven.compiler.release>
1819
</properties>
1920
<dependencyManagement>
2021
<dependencies>
@@ -55,33 +56,6 @@
5556
<module>parsec-jca-java-test</module>
5657
</modules>
5758

58-
<profiles>
59-
<profile>
60-
<id>java1.8</id>
61-
<activation>
62-
<activeByDefault>false</activeByDefault>
63-
<jdk>1.8</jdk>
64-
</activation>
65-
<build>
66-
<pluginManagement>
67-
<plugins>
68-
<plugin>
69-
<groupId>org.apache.maven.plugins</groupId>
70-
<artifactId>maven-compiler-plugin</artifactId>
71-
<version>3.8.1</version>
72-
<configuration>
73-
<source>1.8</source>
74-
<target>1.8</target>
75-
<excludes>
76-
<exclude>module-info.java</exclude>
77-
</excludes>
78-
</configuration>
79-
</plugin>
80-
</plugins>
81-
</pluginManagement>
82-
</build>
83-
</profile>
84-
</profiles>
8559
<build>
8660
<pluginManagement>
8761
<plugins>
@@ -110,6 +84,11 @@
11084
<flattenMode>clean</flattenMode>
11185
</configuration>
11286
</plugin>
87+
<plugin>
88+
<groupId>org.apache.maven.plugins</groupId>
89+
<artifactId>maven-compiler-plugin</artifactId>
90+
<version>3.14.0</version>
91+
</plugin>
11392
</plugins>
11493
</build>
11594
</project>

0 commit comments

Comments
 (0)