Skip to content

Commit 7776f65

Browse files
authored
cfv related bugfix (#584)
1 parent 7236b56 commit 7776f65

File tree

6 files changed

+370
-134
lines changed

6 files changed

+370
-134
lines changed

papermerge/core/features/document/db/api.py

Lines changed: 16 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -226,28 +226,24 @@ def get_docs_by_type(
226226

227227
cf_count = document_type_cf_count(session, document_type_id=type_id)
228228

229-
if order_by is None:
230-
stmt = select_docs_by_type(
231-
document_type_id=type_id,
232-
user_id=user_id,
233-
limit=cf_count * page_size,
234-
offset=cf_count * (page_number - 1) * page_size
235-
)
236-
else:
229+
cfv_column_name = None
230+
231+
if order_by is not None:
237232
cfv_column_name = get_cfv_column_name(session, order_by)
238-
stmt = select_docs_by_type(
239-
document_type_id=type_id,
240-
user_id=user_id,
241-
order_by=order_by,
242-
order=order,
243-
cfv_column_name=cfv_column_name,
244-
limit=cf_count * page_size,
245-
offset=cf_count * (page_number - 1) * page_size
246-
)
247233

248-
rows = session.execute(stmt)
234+
stmt = select_docs_by_type(
235+
document_type_id=type_id,
236+
user_id=user_id,
237+
order_by=order_by,
238+
order=order,
239+
cfv_column_name=cfv_column_name,
240+
limit=cf_count * page_size,
241+
offset=cf_count * (page_number - 1) * page_size
242+
)
243+
249244
ordered_doc_cfvs = OrderedDocumentCFV()
250-
for row in rows:
245+
for row in session.execute(stmt).all():
246+
print(row.title)
251247
entry = DocumentCFVRow(
252248
title=row.title,
253249
doc_id=row.doc_id,
@@ -256,6 +252,7 @@ def get_docs_by_type(
256252
cf_type=row.cf_type,
257253
cf_value=row.cf_value
258254
)
255+
259256
ordered_doc_cfvs.add(entry)
260257

261258
return list(ordered_doc_cfvs)

0 commit comments

Comments
 (0)