Stringify request body for support of old browser versions / devices

[Sv-Th]

Issue

This is a bit of an oddball. We are using openid-client to support device code authorization on our smart tv apps. One of our platforms is Tizen 3.x which has a Chromium 47 browser.

Chrome 47 falls in a bit of an odd spot for browser features:

• fetch api is supported
• URLsearchparams isn't

What we see now is that on these devices, no body is sent with the authenticatedRequest calls.
This due to (we believe) the fetch call not correctly stringifying the body. This is also reproducible locally on PC using an old Chrome version (see below).

The simplest fix for this would be to manually .toString() the body before sending the fetch. But wanted to ask your input before throwing out a pull request.

How to reproduce

Get an old Chrome 47

• windows
• Or find one for your preferred platform

// in browser mentioned above use a URLSearchParams polyfill such as: https://github.com/jerrybendy/url-search-params-polyfill

var foo = new URLSearchParams();
foo.append('foo', 'bar');

fetch('http://<your logserver>', { body: foo }) // empty body received
fetch('http://<your logserver>', { body: foo.toString() }) // body received

Thank you in advance

[panva]

The simplest fix for this would be to manually .toString() the body before sending the fetch. But wanted to ask your input before throwing out a pull request.

Stringifying the body prior to sending fetch would be a breaking API change due to it changing the extensibility expecatation that's available. That being said, because of said extensibility you can call stringify on the bodies before sending a fetch out yourself. That's what customFetch is for.

[Sv-Th]

Makes a lot of sense! Must have overlooked this in my debugging rabbithole, forest for the trees and all that.

Thanks for the fast response 👍