This repository was archived by the owner on May 7, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 858
This repository was archived by the owner on May 7, 2024. It is now read-only.
Unnecessary files are added to the Docker container #813
Copy link
Copy link
Open
Description
.dockerignore should be enriched so that no unnecessary files are added to it.
$ docker run --rm -it --entrypoint /bin/bash pantsel/konga
/app # ls -la
total 512
drwxr-xr-x 1 root root 4096 May 16 2020 .
drwxr-xr-x 1 root root 4096 Jul 26 14:46 ..
-rw-r--r-- 1 root root 44 May 16 2020 .bowerrc
-rw-r--r-- 1 root root 2812 May 16 2020 .dockerignore
-rw-r--r-- 1 root root 169 May 16 2020 .env_example
-rw-r--r-- 1 root root 2851 May 16 2020 .gitignore
-rw-r--r-- 1 root root 85 May 16 2020 .jshintrc
-rw-r--r-- 1 root root 89 May 16 2020 .sailsrc
drwxr-xr-x 2 konga 1200 4096 May 16 2020 .tmp
-rw-r--r-- 1 root root 175 May 16 2020 .travis.yml
-rw-r--r-- 1 root root 11446 May 16 2020 CHANGELOG.md
-rw-r--r-- 1 root root 569 May 16 2020 Dockerfile
-rw-r--r-- 1 root root 2265 May 16 2020 Gruntfile.js
-rw-r--r-- 1 root root 1105 May 16 2020 LICENSE
-rw-r--r-- 1 root root 14871 May 16 2020 README.md
-rw-r--r-- 1 root root 751 May 16 2020 ROADMAP.md
drwxr-xr-x 11 root root 4096 May 16 2020 api
-rw-r--r-- 1 root root 1959 May 16 2020 app.js
drwxr-xr-x 1 root root 4096 May 16 2020 assets
drwxr-xr-x 2 root root 4096 May 16 2020 bin
-rw-r--r-- 1 root root 1555 May 16 2020 bower.json
drwxr-xr-x 2 root root 4096 May 16 2020 certs
drwxr-xr-x 3 root root 4096 May 16 2020 charts
drwxr-xr-x 4 root root 4096 May 16 2020 config
-rw-r--r-- 1 root root 1523 May 16 2020 docker-compose.yml
drwxr-xr-x 2 root root 4096 May 16 2020 docs
-rw-r--r-- 1 root root 333 May 16 2020 dummy.js
-rw-r--r-- 1 root root 196 May 16 2020 ecosystem.config.js
drwxr-xr-x 2 konga 1200 4096 May 16 2020 kongadata
drwxr-xr-x 3 root root 4096 May 16 2020 makedb
drwxr-xr-x 596 root root 20480 May 16 2020 node_modules
-rw-r--r-- 1 root root 335892 May 16 2020 package-lock.json
-rw-r--r-- 1 root root 2154 May 16 2020 package.json
-rwxr-xr-x 1 root root 695 May 16 2020 start.sh
drwxr-xr-x 4 root root 4096 May 16 2020 tasks
drwxr-xr-x 1 konga 1200 4096 May 16 2020 views
For example charts/ is completely useless there, as well as docker-compose.yml and .dockerignore ...
They could be added to the dockerignore file.
Besides this, there is an old Helm chart archive checked in to git, that IMHO could be removed from git altogether.
/app # ls charts/konga/
Chart.yaml README.md konga-1.0.0.tgz templates values.yaml
Moreover, the header of dockerignore says it's a gitignore. Copy & paste :))
Thanks for your time.
Metadata
Metadata
Assignees
Labels
No labels