Skip to content

Commit df0d1b6

Browse files
committed
Removed logging warnings with exceptions as they don't get logged properly by all log providers
1 parent 0b34b23 commit df0d1b6

File tree

2 files changed

+0
-4
lines changed

2 files changed

+0
-4
lines changed

Meraki.Api/AuthenticatedBackingOffHttpClientHandler.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,6 @@ await _options
130130
if (attemptCount >= _options.MaxAttemptCount)
131131
{
132132
_logger.LogError(
133-
ex,
134133
"{LogPrefix}Giving up retrying. Received \"Network is unreachable\" on attempt {AttemptCount}/{MaxAttemptCount}. ({Method} - {Url})",
135134
logPrefix, attemptCount, _options.MaxAttemptCount,
136135
request.Method.ToString(),
@@ -140,7 +139,6 @@ await _options
140139
}
141140

142141
_logger.LogWarning(
143-
ex,
144142
"{LogPrefix}Received \"Network is unreachable\" on attempt {AttemptCount}/{MaxAttemptCount}. ({Method} - {Url})",
145143
logPrefix, attemptCount, _options.MaxAttemptCount,
146144
request.Method.ToString(),
@@ -172,7 +170,6 @@ await _options
172170
}
173171

174172
_logger.LogWarning(
175-
ex,
176173
"{LogPrefix}Received \"Connection reset by peer\" on attempt {AttemptCount}/{MaxAttemptCount}. ({Method} - {Url})",
177174
logPrefix, attemptCount, _options.MaxAttemptCount,
178175
request.Method.ToString(),

Meraki.Api/CustomNewtonsoftJsonContentSerializer.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ public CustomNewtonsoftJsonContentSerializer(MerakiClientOptions options, ILogge
5757
}
5858
catch (JsonSerializationException ex)
5959
{
60-
_logger.LogWarning(ex, "JsonSerializationException: {Message}", ex.Message);
6160
_logger.LogWarning("JsonSerializationException occurred: {Message}", ex.Message);
6261

6362
if (_options.JsonMissingMemberResponseLogLevel != LogLevel.None)

0 commit comments

Comments
 (0)