Skip to content

Commit 72cbae3

Browse files
authored
Improve type hint (#1226)
1 parent cc072bf commit 72cbae3

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

CHANGES.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ Version 3.0.5
44
Unreleased
55

66
- ``Pagination.next()`` enforces ``max_per_page``. :issue:`1201`
7+
- Improve type hint for ``get_or_404`` return value to be non-optional. :pr:`1226`
78

89

910
Version 3.0.4

src/flask_sqlalchemy/extension.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -734,7 +734,7 @@ def get_binds(self) -> dict[sa.Table, sa.engine.Engine]:
734734

735735
def get_or_404(
736736
self, entity: type[_O], ident: t.Any, *, description: str | None = None
737-
) -> t.Optional[_O]:
737+
) -> _O:
738738
"""Like :meth:`session.get() <sqlalchemy.orm.Session.get>` but aborts with a
739739
``404 Not Found`` error instead of returning ``None``.
740740

tests/test_view_query.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,10 +70,11 @@ class Quiz(db.Model):
7070

7171
db.create_all()
7272

73-
item: Quiz = Quiz()
73+
item: Quiz = Quiz(topic="Python")
7474
db.session.add(item)
7575
db.session.commit()
7676
result = db.get_or_404(Quiz, 1)
77+
assert result.topic == "Python"
7778
assert result is item
7879
if hasattr(t, "assert_type"):
7980
t.assert_type(result, Quiz)

0 commit comments

Comments
 (0)