-
Notifications
You must be signed in to change notification settings - Fork 17
Open
Labels
hacktoberfestHacktoberfest eligibleHacktoberfest eligiblenote:good-first-issueA good first issue to get started withA good first issue to get started withnote:ideal-for-contributionAn issue that a contributor can help us withAn issue that a contributor can help us withtype:bugA general bugA general bug
Description
When using --add-modules ALL-MODULE-PATH
as jlink arg to add all modules to the jre, the build fails with: Error: Module all-module-path not found
. Note the lowercase here
Expected Behavior
Build should work
Possible Solution
Maybe there is some toLowerCase()
call?
Steps to Reproduce
- add BP_JVM_JLINK_ENABLED:
true
- add BP_JVM_JLINK_ARGS:
--add-modules ALL-MODULE-PATH --compress=2 --no-header-files --no-man-pages --strip-debug
Motivations
We wanna test and get a feeling for jlink. Currently our application is not modulrized, so we wanna start by trimming the modules from all modules. It also is mentioned in jlink help section to use that shortcut:
Metadata
Metadata
Assignees
Labels
hacktoberfestHacktoberfest eligibleHacktoberfest eligiblenote:good-first-issueA good first issue to get started withA good first issue to get started withnote:ideal-for-contributionAn issue that a contributor can help us withAn issue that a contributor can help us withtype:bugA general bugA general bug