Skip to content

Commit f517cdb

Browse files
authored
log installation failures (#372)
* log installation failures * increase version * fix * fix log * typo
1 parent ac600e7 commit f517cdb

File tree

3 files changed

+14
-3
lines changed

3 files changed

+14
-3
lines changed

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "italia-backend",
3-
"version": "0.3.3",
3+
"version": "0.3.4",
44
"description": "Italia app and web backend",
55
"main": "index.js",
66
"engines": {
@@ -137,4 +137,4 @@
137137
"!src/**/*.d.ts"
138138
]
139139
}
140-
}
140+
}

src/controllers/notificationController.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,11 @@ export default class NotificationController {
4545
const errorOrUser = extractUserFromRequest(req);
4646

4747
if (isLeft(errorOrUser)) {
48-
// Unable to extract the user from the request.
4948
const error = errorOrUser.value;
49+
log.error(
50+
"Unable to extract the user from the request: %s",
51+
error.message
52+
);
5053
return ResponseErrorInternal(error.message);
5154
}
5255

src/services/notificationService.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ import {
2222
INotificationTemplate,
2323
toFiscalCodeHash
2424
} from "../types/notification";
25+
import { log } from "../utils/logger";
2526

2627
/**
2728
* A template suitable for Apple's APNs.
@@ -105,6 +106,13 @@ export default class NotificationService {
105106
// tslint:disable-next-line:no-any
106107
(azureInstallation as any) as string,
107108
(error, response) => {
109+
if (error) {
110+
log.error(
111+
"Unable to create installation: %s (error=%s)",
112+
JSON.stringify(azureInstallation),
113+
error.message
114+
);
115+
}
108116
return resolve(this.buildResponse(error, response));
109117
}
110118
);

0 commit comments

Comments
 (0)