display user decoding errors (#261)

* display user decoding errors

* fix tests

Author: gunzip

src/controllers/__tests__/authenticationController.test.ts

@@ -250,7 +250,9 @@ describe("AuthenticationController#acs", () => {
 
     expect(res.json).toHaveBeenCalledWith({
       ...anErrorResponse,
-      detail: "Unable to decode the user"
+      detail: expect.stringContaining(
+        "value.email is not a string that represents an email address"
+      )
     });
     expect(mockSet).not.toHaveBeenCalled();
   });
@@ -340,7 +342,7 @@ describe("AuthenticationController#logout", () => {
     expect(res.status).toHaveBeenCalledWith(500);
     expect(res.json).toHaveBeenCalledWith({
       ...anErrorResponse,
-      detail: "Unable to decode the user"
+      detail: expect.stringContaining("value.family_name is not a string")
     });
   });
 

src/controllers/__tests__/messagesController.test.ts

@@ -123,7 +123,7 @@ describe("MessagesController#getMessagesByUser", () => {
     expect(mockGetMessagesByUser).not.toBeCalled();
     expect(res.json).toHaveBeenCalledWith({
       ...anErrorResponse,
-      detail: "Unable to decode the user"
+      detail: expect.stringContaining("Cannot extract the user from request")
     });
   });
 });
@@ -178,7 +178,7 @@ describe("MessagesController#getMessage", () => {
     expect(mockGetMessage).not.toBeCalled();
     expect(res.json).toHaveBeenCalledWith({
       ...anErrorResponse,
-      detail: "Unable to decode the user"
+      detail: expect.stringContaining("Cannot extract the user from request")
     });
   });
 });

src/controllers/__tests__/notificationController.test.ts

@@ -199,7 +199,9 @@ describe("NotificationController#createOrUpdateInstallation", () => {
 
     expect(res.json).toHaveBeenCalledWith({
       ...anErrorResponse,
-      detail: "Unable to decode the user"
+      detail: expect.stringContaining(
+        "value.fiscal_code is not a string that matches the pattern"
+      )
     });
   });
 

src/controllers/__tests__/profileController.test.ts

@@ -138,7 +138,7 @@ describe("ProfileController#getProfile", () => {
     expect(mockGetProfile).not.toBeCalled();
     expect(res.json).toHaveBeenCalledWith({
       ...anErrorResponse,
-      detail: "Unable to decode the user"
+      detail: expect.stringContaining("Cannot extract the user from request")
     });
   });
 });
@@ -196,7 +196,7 @@ describe("ProfileController#upsertProfile", () => {
     expect(mockUpsertProfile).not.toBeCalled();
     expect(res.json).toHaveBeenCalledWith({
       ...anErrorResponse,
-      detail: "Unable to decode the user"
+      detail: expect.stringContaining("Cannot extract the user from request")
     });
   });
 

src/controllers/__tests__/serviceController.test.ts

@@ -111,7 +111,7 @@ describe("serviceController#getService", () => {
     expect(mockGetService).not.toBeCalled();
     expect(res.json).toHaveBeenCalledWith({
       ...anErrorResponse,
-      detail: "Unable to decode the user"
+      detail: expect.stringContaining("Cannot extract the user from request")
     });
   });
 });

src/types/user.ts

@@ -6,8 +6,10 @@
 import * as express from "express";
 import { Either, left } from "fp-ts/lib/Either";
 import { fromNullable, none, Option, some, tryCatch } from "fp-ts/lib/Option";
-import * as t from "io-ts";
 import { number, string } from "io-ts";
+import * as t from "io-ts";
+import { JSONFromString } from "io-ts-types";
+import { readableReport } from "italia-ts-commons/lib/reporters";
 import { DOMParser } from "xmldom";
 import { log } from "../utils/logger";
 import { EmailAddress } from "./api/EmailAddress";
@@ -51,8 +53,6 @@ export const SpidUser = t.interface({
 
 export type SpidUser = t.TypeOf<typeof SpidUser>;
 
-const messageErrorOnDecodeUser = "Unable to decode the user";
-
 /**
  * Converts a SPID User to a Proxy User.
  */
@@ -83,7 +83,7 @@ export function toAppUser(
 // tslint:disable-next-line:no-any
 export function validateSpidUser(value: any): Either<Error, SpidUser> {
   if (!value.hasOwnProperty("fiscalNumber")) {
-    return left(new Error(messageErrorOnDecodeUser));
+    return left(new Error("Cannot decode a user without a fiscalNumber"));
   }
 
   // Remove the international prefix from fiscal number.
@@ -131,8 +131,10 @@ export function validateSpidUser(value: any): Either<Error, SpidUser> {
 
   const result = SpidUser.decode(valueWithDefaultSPIDLevel);
 
-  return result.mapLeft(() => {
-    return new Error(messageErrorOnDecodeUser);
+  return result.mapLeft(err => {
+    return new Error(
+      "Cannot validate SPID user object: " + readableReport(err)
+    );
   });
 }
 
@@ -144,22 +146,27 @@ export function extractUserFromRequest(
 ): Either<Error, User> {
   const result = User.decode(from.user);
 
-  return result.mapLeft(() => {
-    return new Error(messageErrorOnDecodeUser);
+  // tslint:disable-next-line:no-identical-functions
+  return result.mapLeft(err => {
+    return new Error(
+      "Cannot extract the user from request: " + readableReport(err)
+    );
   });
 }
 
 /**
  * Extracts a user from a json string.
  */
 export function extractUserFromJson(from: string): Either<Error, User> {
-  const json = JSON.parse(from);
-
-  const result = User.decode(json);
-
-  return result.mapLeft(() => {
-    return new Error(messageErrorOnDecodeUser);
-  });
+  return JSONFromString.decode(from)
+    .mapLeft(
+      err => new Error("Cannot parse the user JSON:" + readableReport(err))
+    )
+    .chain(json =>
+      User.decode(json).mapLeft(
+        err => new Error("Cannot decode the user JSON: " + readableReport(err))
+      )
+    );
 }
 
 /**