Skip to content

Commit 32a4e3a

Browse files
authored
Merge pull request #5 from sumocoders/master
DBAL Types always need to know how to handle null
2 parents ecc03be + be54586 commit 32a4e3a

File tree

3 files changed

+15
-3
lines changed

3 files changed

+15
-3
lines changed

features/generate/domain/resources/php71/Backend/Modules/TestModule/Domain/MyTestEntity/MyValueObjectDBALType.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,12 @@ public function getName(): string
1212
return 'testmodule_mytestentity_myvalueobject';
1313
}
1414

15-
public function convertToPHPValue($myValueObjectDBALType, AbstractPlatform $platform): MyValueObject
15+
public function convertToPHPValue($myValueObjectDBALType, AbstractPlatform $platform): ?MyValueObject
1616
{
17+
if ($myValueObjectDBALType === null) {
18+
return null;
19+
}
20+
1721
return new MyValueObject($myValueObjectDBALType);
1822
}
1923

features/generate/domain/resources/php71/Standalone/MyValueObjectDBALType.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,12 @@ public function getName(): string
1212
return 'myvalueobject';
1313
}
1414

15-
public function convertToPHPValue($myValueObjectDBALType, AbstractPlatform $platform): MyValueObject
15+
public function convertToPHPValue($myValueObjectDBALType, AbstractPlatform $platform): ?MyValueObject
1616
{
17+
if ($myValueObjectDBALType === null) {
18+
return null;
19+
}
20+
1721
return new MyValueObject($myValueObjectDBALType);
1822
}
1923

src/Domain/ValueObject/ValueObjectDBALType.php71.php.twig

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,12 @@ final class {{ class.className.name }} extends StringType
1212
return '{{ class.name }}';
1313
}
1414
15-
public function convertToPHPValue(${{ class.className.forParameter }}, AbstractPlatform $platform): {{ class.valueObjectClassName.name }}
15+
public function convertToPHPValue(${{ class.className.forParameter }}, AbstractPlatform $platform): ?{{ class.valueObjectClassName.name }}
1616
{
17+
if (${{ class.className.forParameter }} === null) {
18+
return null;
19+
}
20+
1721
return new {{ class.valueObjectClassName.name }}(${{ class.className.forParameter }});
1822
}
1923

0 commit comments

Comments
 (0)