Add hasItem

Author: bajb

phpunit.xml

@@ -10,7 +10,7 @@
          processIsolation="false"
          stopOnFailure="false"
          syntaxCheck="false"
-  >
+>
   <testsuites>
     <testsuite>
       <directory>tests</directory>

src/ConfigProviderInterface.php

@@ -71,6 +71,14 @@ public function has($name);
    */
   public function getItem($section, $key, $default = null);
 
+  /**
+   * @param string $section Section Name
+   * @param string $key     Config Item Key
+   *
+   * @return bool
+   */
+  public function hasItem($section, $key);
+
   /**
    * Add an item to the configuration
    *

src/Provider/AbstractConfigProvider.php

@@ -1,6 +1,7 @@
 <?php
 namespace Packaged\Config\Provider;
 
+use Exception;
 use Packaged\Config\ConfigProviderInterface;
 use Packaged\Config\ConfigSectionInterface;
 
@@ -74,6 +75,24 @@ public function getItem($section, $key, $default = null)
     return $this->getSection($section)->getItem($key, $default);
   }
 
+  /**
+   * @param string $section Section Name
+   * @param string $key     Config Item Key
+   *
+   * @return bool
+   */
+  public function hasItem($section, $key)
+  {
+    try
+    {
+      return $this->getSection($section)->has($key);
+    }
+    catch(Exception $e)
+    {
+      return false;
+    }
+  }
+
   /**
    * Retrieve all configuration sections
    *

tests/ConfigProviderBaseTest.php

@@ -212,6 +212,19 @@ public function testSectionExists()
     $this->assertFalse($provider->sectionExists("database"));
   }
 
+  /**
+   * @depends testValidProvider
+   */
+  public function testHasItem()
+  {
+    $provider = $this->getConfigProvider();
+    $this->assertFalse($provider->hasItem('invalidsection', 'invaliditem'));
+    $provider->addItem("newsection", "newitem", "newvalue");
+    $this->assertFalse($provider->hasItem('newsection', 'invaliditem'));
+    $this->assertFalse($provider->hasItem('invalidsection', 'newitem'));
+    $this->assertTrue($provider->hasItem('newsection', 'newitem'));
+  }
+
   /**
    * @depends testValidProvider
    */

tests/IniCachedConfigProviderTest.php

@@ -68,29 +68,20 @@ public function testCachedLoad()
     $contents = file_get_contents(dirname(__DIR__) . '/testData/cached.ini');
     file_put_contents($tempFile, $contents);
 
-    $provider = new \Packaged\Config\Provider\Ini\CachedIniConfigProvider(
-      [$dir], $filename, false, 3
-    );
+    $provider = new \Packaged\Config\Provider\Ini\CachedIniConfigProvider([$dir], $filename, false, 3);
     $this->assertEquals("value2", $provider->getItem("main", "item2"));
 
     // replace the value of item2 in the temp file
-    file_put_contents(
-      $tempFile,
-      str_replace('value2', 'new_value_2', $contents)
-    );
+    file_put_contents($tempFile, str_replace('value2', 'new_value_2', $contents));
 
     // 3 seconds should not have passed yet so the value should be returned from the cache
-    $provider = new \Packaged\Config\Provider\Ini\CachedIniConfigProvider(
-      [$dir], $filename, false, 3
-    );
+    $provider = new \Packaged\Config\Provider\Ini\CachedIniConfigProvider([$dir], $filename, false, 3);
     $this->assertEquals("value2", $provider->getItem("main", "item2"));
 
     sleep(3);
 
     // TTL expired, should load from the file again
-    $provider = new \Packaged\Config\Provider\Ini\CachedIniConfigProvider(
-      [$dir], $filename, false, 3
-    );
+    $provider = new \Packaged\Config\Provider\Ini\CachedIniConfigProvider([$dir], $filename, false, 3);
     $this->assertEquals("new_value_2", $provider->getItem("main", "item2"));
 
     unlink($tempFile);