Skip to content

Commit 0dcd4e9

Browse files
authored
Merge pull request #42 from paceaux/develop
Fixes screenshot filenames, updates cheerio, updates packages
2 parents e871bd3 + ab7f446 commit 0dcd4e9

File tree

8 files changed

+11752
-2621
lines changed

8 files changed

+11752
-2621
lines changed

.vscode/launch.json

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,22 @@
55
"version": "0.2.0",
66
"configurations": [
77
{
8-
"type": "pwa-node",
8+
"type": "node",
99
"request": "launch",
1010
"name": "Launch Program",
11+
"args": [
12+
"-u", // url
13+
"https://frankmtaylor.com/sitemap.xml",
14+
"-l", // limit. raise or lower for more pages AND screenshots
15+
"10",
16+
"-c", // screengrabs.
17+
"-s", // the selector
18+
"h1"
19+
],
1120
"skipFiles": [
1221
"<node_internals>/**"
1322
],
14-
"program": "${workspaceFolder}\\index.js"
23+
"program": "${workspaceFolder}/cli.js"
1524
}
1625
]
1726
}

README.md

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,19 @@ Pages not showing up that should? Check the `log.txt` for any issues.
1414

1515
### Prerequisites
1616

17-
- Node LTS (as of September 2023, Node 18.16.0)
17+
- Node LTS (as of August 2024, Node 20.16.0)
1818

19-
- If you want to use the `-d` or `-c` (`--isSpa` and `--takeScreenshots` options), this requires Puppeteer which in turn requires Chromium.
19+
#### Some possible Puppeteer setup for Mac Users
2020

21-
- If running this on a Mac, be sure you install chromium without a quarantine flag: `brew install chromium --no-quarantine`
21+
If you want to use the `-d` or `-c` (`--isSpa` and `--takeScreenshots` ) options, this requires Puppeteer which in turn requires Chromium.
22+
23+
You may (or may not) need `PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true` and `PUPPETEER_EXECUTABLE_PATH` environment variables set. They were necessary for older versions of Puppeteer and seem to be unnecessary for new ones.
24+
25+
If you're having issues, run `printenv` in your terminal to see if those variables are set. If they are, you may need to unset them with `unset PUPPETEER_SKIP_CHROMIUM_DOWNLOAD` and `unset PUPPETEER_EXECUTABLE_PATH`. Then `source ~/.bashrc` or `source ~/.zshrc` to be sure, and run `printenv` once again.
26+
27+
But if they aren't set, you may need to do this.
28+
29+
After you play with those variables, reinstall this package.
2230

2331
### Running on-demand
2432

0 commit comments

Comments
 (0)