Bump SDK version to c8be658 (#410)

Depends on oxidecomputer/oxide.go#274

Closes: #403

Author: karencfv

go.mod

@@ -11,7 +11,7 @@ require (
 	github.com/hashicorp/terraform-plugin-log v0.9.0
 	github.com/hashicorp/terraform-plugin-sdk/v2 v2.36.1
 	github.com/hashicorp/terraform-plugin-testing v1.12.0
-	github.com/oxidecomputer/oxide.go v0.3.0
+	github.com/oxidecomputer/oxide.go v0.3.1-0.20250328231836-c8be65844352
 	github.com/stretchr/testify v1.10.0
 )
 

go.sum

@@ -136,8 +136,8 @@ github.com/mitchellh/reflectwalk v1.0.2 h1:G2LzWKi524PWgd3mLHV8Y5k7s6XUvT0Gef6zx
 github.com/mitchellh/reflectwalk v1.0.2/go.mod h1:mSTlrgnPZtwu0c4WaC2kGObEpuNDbx0jmZXqmk4esnw=
 github.com/oklog/run v1.0.0 h1:Ru7dDtJNOyC66gQ5dQmaCa0qIsAUFY3sFpK1Xk8igrw=
 github.com/oklog/run v1.0.0/go.mod h1:dlhp/R75TPv97u0XWUtDeV/lRKWPKSdTuV0TZvrmrQA=
-github.com/oxidecomputer/oxide.go v0.3.0 h1:I5l9njXo1lp1Tqp63y8HKw19HOpuEV8RRkJqpXoxcdQ=
-github.com/oxidecomputer/oxide.go v0.3.0/go.mod h1:FECb3qr0RSxGnHIiH6DsUGdkTcY/WeKN1evZCTQ3fy4=
+github.com/oxidecomputer/oxide.go v0.3.1-0.20250328231836-c8be65844352 h1:C7+yo9PnkjVkS4UvhX0gMUQhzaBbS5L8WTsEraSdgyM=
+github.com/oxidecomputer/oxide.go v0.3.1-0.20250328231836-c8be65844352/go.mod h1:yNLdQdroM42/yDIFlCsLAR9PawAdeJZDgHdAx+wcywg=
 github.com/pelletier/go-toml v1.9.5 h1:4yBQzkHv+7BHq2PQUZF3Mx0IYxG7LsP222s7Agd3ve8=
 github.com/pelletier/go-toml v1.9.5/go.mod h1:u1nR/EPcESfeI/szUZKdtJ0xRNbUoANCkoOuaOx1Y+c=
 github.com/pjbgf/sha1cd v0.3.0 h1:4D5XXmUUBUl/xQ6IjCkEAbqXskkq/4O7LmGn0AqMDs4=

internal/provider/data_source_images.go

@@ -164,7 +164,7 @@ func (d *imagesDataSource) Read(ctx context.Context, req datasource.ReadRequest,
 	// Seems unlikely anyone will have more than one billion images.
 	params := oxide.ImageListParams{
 		Project: oxide.NameOrId(state.ProjectID.ValueString()),
-		Limit:   1000000000,
+		Limit:   oxide.NewPointer(1000000000),
 		SortBy:  oxide.NameOrIdSortModeIdAscending,
 	}
 	images, err := d.client.ImageList(ctx, params)

internal/provider/data_source_projects.go

@@ -115,7 +115,7 @@ func (d *projectsDataSource) Read(ctx context.Context, req datasource.ReadReques
 	// as there are in reality. For now I'll use the List method with a limit of 1,000,000,000 results.
 	// Seems unlikely anyone will have more than one billion projects.
 	params := oxide.ProjectListParams{
-		Limit:  1000000000,
+		Limit:  oxide.NewPointer(1000000000),
 		SortBy: oxide.NameOrIdSortModeNameDescending,
 	}
 	projects, err := d.client.ProjectList(ctx, params)

internal/provider/resource_instance.go

@@ -821,7 +821,7 @@ func newAttachedDisksSet(ctx context.Context, client *oxide.Client, instanceID s
 	var diags diag.Diagnostics
 
 	params := oxide.InstanceDiskListParams{
-		Limit:    1000000000,
+		Limit:    oxide.NewPointer(1000000000),
 		Instance: oxide.NameOrId(instanceID),
 	}
 	disks, err := client.InstanceDiskList(ctx, params)
@@ -851,7 +851,7 @@ func newAssociatedSSHKeysOnCreateSet(ctx context.Context, client *oxide.Client,
 	var diags diag.Diagnostics
 
 	params := oxide.InstanceSshPublicKeyListParams{
-		Limit:    1000000000,
+		Limit:    oxide.NewPointer(1000000000),
 		Instance: oxide.NameOrId(instanceID),
 	}
 	keys, err := client.InstanceSshPublicKeyList(ctx, params)
@@ -919,7 +919,7 @@ func newAttachedNetworkInterfacesModel(ctx context.Context, client *oxide.Client
 
 	params := oxide.InstanceNetworkInterfaceListParams{
 		Instance: oxide.NameOrId(instanceID),
-		Limit:    1000000000,
+		Limit:    oxide.NewPointer(1000000000),
 	}
 	nics, err := client.InstanceNetworkInterfaceList(ctx, params)
 	if err != nil {

internal/provider/resource_ip_pool.go

@@ -208,7 +208,7 @@ func (r *ipPoolResource) Read(ctx context.Context, req resource.ReadRequest, res
 	// Append information about IP Pool ranges
 	listParams := oxide.IpPoolRangeListParams{
 		Pool:  oxide.NameOrId(ipPool.Id),
-		Limit: 1000000000,
+		Limit: oxide.NewPointer(1000000000),
 	}
 	ipPoolRanges, err := r.client.IpPoolRangeList(ctx, listParams)
 	if err != nil {
@@ -355,7 +355,7 @@ func (r *ipPoolResource) Delete(ctx context.Context, req resource.DeleteRequest,
 		ctx,
 		oxide.IpPoolRangeListParams{
 			Pool:  oxide.NameOrId(state.ID.ValueString()),
-			Limit: 1000000000,
+			Limit: oxide.NewPointer(1000000000),
 		},
 	)
 	if err != nil {

internal/provider/resource_ip_pool_silo_link.go

@@ -168,7 +168,7 @@ func (r *ipPoolSiloLinkResource) Read(ctx context.Context, req resource.ReadRequ
 
 	params := oxide.IpPoolSiloListParams{
 		Pool:   oxide.NameOrId(state.IPPoolID.ValueString()),
-		Limit:  1000000000,
+		Limit:  oxide.NewPointer(1000000000),
 		SortBy: oxide.IdSortModeIdAscending,
 	}
 

internal/provider/resource_ip_pool_silo_link_test.go

@@ -195,7 +195,7 @@ func testAccIPPoolSiloLinkDestroy(s *terraform.State) error {
 		siloID := rs.Primary.Attributes["silo_id"]
 		params := oxide.IpPoolSiloListParams{
 			Pool:   oxide.NameOrId(oxide.NameOrId(ipPoolID)),
-			Limit:  1000000000,
+			Limit:  oxide.NewPointer(1000000000),
 			SortBy: oxide.IdSortModeIdAscending,
 		}
 

internal/provider/resource_vpc_firewall_rules.go

@@ -509,10 +509,11 @@ func newVPCFirewallRulesUpdateBody(rules []vpcFirewallRulesResourceRuleModel) *o
 			Description: rule.Description.ValueString(),
 			Direction:   oxide.VpcFirewallRuleDirection(rule.Direction.ValueString()),
 			Name:        oxide.Name(rule.Name.ValueString()),
-			Priority:    int(rule.Priority.ValueInt64()),
-			Status:      oxide.VpcFirewallRuleStatus(rule.Status.ValueString()),
-			Filters:     newFilterTypeFromModel(rule.Filters),
-			Targets:     newTargetTypeFromModel(rule.Targets),
+			// We can safely dereference rule.Priority as it's a required field
+			Priority: oxide.NewPointer(int(*rule.Priority.ValueInt64Pointer())),
+			Status:   oxide.VpcFirewallRuleStatus(rule.Status.ValueString()),
+			Filters:  newFilterTypeFromModel(rule.Filters),
+			Targets:  newTargetTypeFromModel(rule.Targets),
 		}
 
 		updateRules = append(updateRules, r)
@@ -527,12 +528,13 @@ func newVPCFirewallRulesModel(rules []oxide.VpcFirewallRule) ([]vpcFirewallRules
 
 	for _, rule := range rules {
 		m := vpcFirewallRulesResourceRuleModel{
-			Action:       types.StringValue(string(rule.Action)),
-			Description:  types.StringValue(rule.Description),
-			Direction:    types.StringValue(string(rule.Direction)),
-			ID:           types.StringValue(rule.Id),
-			Name:         types.StringValue(string(rule.Name)),
-			Priority:     types.Int64Value(int64(rule.Priority)),
+			Action:      types.StringValue(string(rule.Action)),
+			Description: types.StringValue(rule.Description),
+			Direction:   types.StringValue(string(rule.Direction)),
+			ID:          types.StringValue(rule.Id),
+			Name:        types.StringValue(string(rule.Name)),
+			// We can safely dereference rule.Priority as it's a required field
+			Priority:     types.Int64Value(int64(*rule.Priority)),
 			Status:       types.StringValue(string(rule.Status)),
 			Targets:      newTargetsModelFromResponse(rule.Targets),
 			TimeCreated:  types.StringValue(rule.TimeCreated.String()),

internal/provider/resource_vpc_firewall_rules_test.go

@@ -113,7 +113,7 @@ resource "oxide_vpc_firewall_rules" "{{.BlockName}}" {
 		 description = "custom deny"
 		 name = "custom-deny-http"
 		 direction = "inbound"
-		 priority = 50
+		 priority = 0
 		 status = "enabled"
 		 filters = {
 		   ports = ["8123"]
@@ -290,7 +290,7 @@ func checkResourceFirewallRulesUpdate(resourceName string) resource.TestCheckFun
 		resource.TestCheckResourceAttr(resourceName, "rules.0.filters.protocols.0", "ICMP"),
 		resource.TestCheckResourceAttrSet(resourceName, "rules.0.id"),
 		resource.TestCheckResourceAttr(resourceName, "rules.0.name", "custom-deny-http"),
-		resource.TestCheckResourceAttr(resourceName, "rules.0.priority", "50"),
+		resource.TestCheckResourceAttr(resourceName, "rules.0.priority", "0"),
 		resource.TestCheckResourceAttr(resourceName, "rules.0.status", "enabled"),
 		resource.TestCheckResourceAttr(resourceName, "rules.0.targets.0.type", "subnet"),
 		resource.TestCheckResourceAttr(resourceName, "rules.0.targets.0.value", "default"),