generate: add network types to nullable exception

sudomateo · sudomateo · commit 86e49ef6e9ba · 2025-06-26T19:06:40.000-04:00
Added network types to the nullable exception.
diff --git a/internal/generate/exceptions.go b/internal/generate/exceptions.go
@@ -26,5 +26,8 @@ func nullable() []string {
 	// the usage of this type. Remove when this is fixed in the upstream API
 	return []string{
 		"InstanceDiskAttachment",
+		"LldpLinkConfig",
+		"TxEqConfig",
+		"TxEqConfig2",
 	}
 }
diff --git a/internal/generate/main.go b/internal/generate/main.go
@@ -9,6 +9,7 @@ import (
 	"net/url"
 	"os"
 	"path/filepath"
+	"strings"
 
 	"github.com/getkin/kin-openapi/openapi3"
 )
@@ -58,7 +59,7 @@ func loadAPIFromFile(file string) (*openapi3.T, error) {
 	if err != nil {
 		return nil, fmt.Errorf("error retrieving Omicron version: %v", err)
 	}
-	ov := string(omicronVersion)
+	ov := strings.TrimSpace(string(omicronVersion))
 
 	// TODO: actually host the spec here.
 	// uri := "https://api.oxide.computer"
diff --git a/oxide/types.go b/oxide/types.go

Original file line number	Diff line number	Diff line change
`@@ -26,5 +26,8 @@ func nullable() []string {`
`26`	`26`	`// the usage of this type. Remove when this is fixed in the upstream API`
`27`	`27`	`return []string{`
`28`	`28`	`"InstanceDiskAttachment",`
	`29`	`+ "LldpLinkConfig",`
	`30`	`+ "TxEqConfig",`
	`31`	`+ "TxEqConfig2",`
`29`	`32`	`}`
`30`	`33`	`}`
Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,7 @@ import (`
`9`	`9`	`"net/url"`
`10`	`10`	`"os"`
`11`	`11`	`"path/filepath"`
	`12`	`+ "strings"`
`12`	`13`
`13`	`14`	`"github.com/getkin/kin-openapi/openapi3"`
`14`	`15`	`)`
`@@ -58,7 +59,7 @@ func loadAPIFromFile(file string) (*openapi3.T, error) {`
`58`	`59`	`if err != nil {`
`59`	`60`	`return nil, fmt.Errorf("error retrieving Omicron version: %v", err)`
`60`	`61`	`}`
`61`		`- ov := string(omicronVersion)`
	`62`	`+ ov := strings.TrimSpace(string(omicronVersion))`
`62`	`63`
`63`	`64`	`// TODO: actually host the spec here.`
`64`	`65`	`// uri := "https://api.oxide.computer"`