Skip to content

Commit 855352f

Browse files
authored
go: update to 1.24 (#291)
Update to Go 1.24. Also, update the dependencies to be compatible with Go 1.24.
1 parent 2e4943b commit 855352f

File tree

6 files changed

+15
-15
lines changed

6 files changed

+15
-15
lines changed

.changelog/v0.5.0.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[[breaking]]
2-
title = ""
3-
description = ""
2+
title = "Update to Go 1.24"
3+
description = "Updated the SDK's Go version to Go 1.24. Consumers of this SDK will need to update to Go 1.24 as well. [#291](https://github.com/oxidecomputer/oxide.go/pull/291)"
44

55
[[features]]
66
title = ""
@@ -12,4 +12,4 @@ description = "All arrays that are nullable in the API no longer have `omitempty
1212

1313
[[enhancements]]
1414
title = ""
15-
description = ""
15+
description = ""

.github/workflows/build-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
- uses: actions/checkout@v4
1212
- uses: actions/setup-go@v5
1313
with:
14-
go-version: "1.x"
14+
go-version-file: "go.mod"
1515
- name: build
1616
shell: bash
1717
run: |

.github/workflows/generate.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
ref: ${{ github.event.pull_request.head.ref }}
2424
- uses: actions/setup-go@v5
2525
with:
26-
go-version: "1.x"
26+
go-version-file: "go.mod"
2727
- name: Run generate
2828
shell: bash
2929
run: |

.github/workflows/make-release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
- uses: actions/checkout@v4
1212
- uses: actions/setup-go@v5
1313
with:
14-
go-version: "1.x"
14+
go-version-file: "go.mod"
1515
- name: Run make generate
1616
run: |
1717
make generate

Makefile

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -84,10 +84,10 @@ help:
8484
# This way linting tools don't need to be downloaded/installed every time you
8585
# want to run the linters or generate the SDK.
8686
VERSION_DIR:=$(GOBIN)/versions
87-
VERSION_GOIMPORTS:=v0.26.0
88-
VERSION_GOLANGCILINT:=v1.61.0
89-
VERSION_STATICCHECK:=2024.1.1
90-
VERSION_WHATSIT:=1f5eb3ea
87+
VERSION_GOIMPORTS:=v0.33.0
88+
VERSION_GOLANGCILINT:=v1.64.8
89+
VERSION_STATICCHECK:=2025.1.1
90+
VERSION_WHATSIT:=053446d
9191

9292
tools: $(GOBIN)/golangci-lint $(GOBIN)/goimports $(GOBIN)/staticcheck
9393

@@ -104,23 +104,23 @@ $(VERSION_DIR)/.version-golangci-lint-$(VERSION_GOLANGCILINT): | $(VERSION_DIR)
104104
@ echo $(VERSION_GOLANGCILINT) > $(VERSION_DIR)/.version-golangci-lint-$(VERSION_GOLANGCILINT)
105105

106106
$(GOBIN)/golangci-lint: $(VERSION_DIR)/.version-golangci-lint-$(VERSION_GOLANGCILINT) | $(GOBIN)
107-
@ echo "-> Installing golangci-lint..."
107+
@ echo "-> Installing golangci-lint $(VERSION_GOLANGCILINT)..."
108108
@ curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh| sh -s -- -b $(GOBIN) $(VERSION_GOLANGCILINT)
109109

110110
$(VERSION_DIR)/.version-goimports-$(VERSION_GOIMPORTS): | $(VERSION_DIR)
111111
@ rm -f $(VERSION_DIR)/.version-goimports-*
112112
@ echo $(VERSION_GOIMPORTS) > $(VERSION_DIR)/.version-goimports-$(VERSION_GOIMPORTS)
113113

114114
$(GOBIN)/goimports: $(VERSION_DIR)/.version-goimports-$(VERSION_GOIMPORTS) | $(GOBIN)
115-
@ echo "-> Installing goimports..."
115+
@ echo "-> Installing goimports $(VERSION_GOIMPORTS)..."
116116
@ go install golang.org/x/tools/cmd/goimports@$(VERSION_GOIMPORTS)
117117

118118
$(VERSION_DIR)/.version-staticcheck-$(VERSION_STATICCHECK): | $(VERSION_DIR)
119119
@ rm -f $(VERSION_DIR)/.version-staticcheck-*
120120
@ echo $(VERSION_STATICCHECK) > $(VERSION_DIR)/.version-staticcheck-$(VERSION_STATICCHECK)
121121

122122
$(GOBIN)/staticcheck: $(VERSION_DIR)/.version-staticcheck-$(VERSION_STATICCHECK) | $(GOBIN)
123-
@ echo "-> Installing staticcheck..."
123+
@ echo "-> Installing staticcheck $(VERSION_STATICCHECK)..."
124124
@ go install honnef.co/go/tools/cmd/staticcheck@$(VERSION_STATICCHECK)
125125

126126
$(VERSION_DIR)/.version-whatsit-$(VERSION_WHATSIT): | $(VERSION_DIR)
@@ -129,5 +129,5 @@ $(VERSION_DIR)/.version-whatsit-$(VERSION_WHATSIT): | $(VERSION_DIR)
129129

130130
# TODO: actually release a version of whatsit to use the tag flag
131131
$(GOBIN)/whatsit: $(VERSION_DIR)/.version-whatsit-$(VERSION_WHATSIT) | $(GOBIN)
132-
@ echo "-> Installing whatsit..."
132+
@ echo "-> Installing whatsit $(VERSION_WHATSIT)..."
133133
@ cargo install --git ssh://git@github.com/oxidecomputer/whatsit.git --rev $(VERSION_WHATSIT) --branch main --root ./

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module github.com/oxidecomputer/oxide.go
22

3-
go 1.22.5
3+
go 1.24.3
44

55
require (
66
github.com/getkin/kin-openapi v0.132.0

0 commit comments

Comments
 (0)