Skip to content

Commit 80e9922

Browse files
authored
Add cmake as SunOS builder dependency (#8233)
After running `pfexec ./tools/install_builder_prerequisites.sh -y`, `cargo build -p end-to-end-tests --bin dhcp-server --release` fails during compilation if cmake is not installed by other means: ``` error: failed to run custom build command for `aws-lc-sys v0.26.0` Caused by: process didn't exit successfully: `/home/trey/git/omicron2/target/debug/build/aws-lc-sys-fc21ff594f15ae53/build-script-main` (exit status: 101) --- stdout cargo:rerun-if-env-changed=AWS_LC_SYS_NO_PREFIX cargo:rerun-if-env-changed=AWS_LC_SYS_PREGENERATING_BINDINGS cargo:rerun-if-env-changed=AWS_LC_SYS_EXTERNAL_BINDGEN cargo:rerun-if-env-changed=AWS_LC_SYS_NO_ASM cargo:rerun-if-env-changed=AWS_LC_SYS_CFLAGS cargo:rerun-if-env-changed=AWS_LC_SYS_PREBUILT_NASM cargo:rerun-if-env-changed=AWS_LC_SYS_C_STD cargo:rerun-if-env-changed=AWS_LC_SYS_CMAKE_BUILDER cargo:rerun-if-env-changed=AWS_LC_SYS_STATIC cargo:rerun-if-env-changed=CMAKE --- stderr Missing dependency: cmake thread 'main' panicked at /home/trey/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/aws-lc-sys-0.26.0/builder/main.rs:382:40: called `Result::unwrap()` on an `Err` value: "Required build dependency is missing. Halting build." note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace Failed to run command -- will try 2 more times Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.40s Running `target/debug/xtask download cockroach clickhouse console dendrite-stub maghemite-mgd transceiver-control` Compiling aws-lc-sys v0.26.0 error: failed to run custom build command for `aws-lc-sys v0.26.0` Caused by: process didn't exit successfully: `/home/trey/git/omicron2/target/debug/build/aws-lc-sys-fc21ff594f15ae53/build-script-main` (exit status: 101) --- stdout cargo:rerun-if-env-changed=AWS_LC_SYS_NO_PREFIX cargo:rerun-if-env-changed=AWS_LC_SYS_PREGENERATING_BINDINGS cargo:rerun-if-env-changed=AWS_LC_SYS_EXTERNAL_BINDGEN cargo:rerun-if-env-changed=AWS_LC_SYS_NO_ASM cargo:rerun-if-env-changed=AWS_LC_SYS_CFLAGS cargo:rerun-if-env-changed=AWS_LC_SYS_PREBUILT_NASM cargo:rerun-if-env-changed=AWS_LC_SYS_C_STD cargo:rerun-if-env-changed=AWS_LC_SYS_CMAKE_BUILDER cargo:rerun-if-env-changed=AWS_LC_SYS_STATIC cargo:rerun-if-env-changed=CMAKE --- stderr Missing dependency: cmake thread 'main' panicked at /home/trey/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/aws-lc-sys-0.26.0/builder/main.rs:382:40: called `Result::unwrap()` on an `Err` value: "Required build dependency is missing. Halting build." note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace ``` Manually installing cmake with `pfexec pkg install cmake` resolves the issue. This commit adds `cmake` as a dependency for SunOS systems. Signed-off-by: Trey Aspelund <trey@oxidecomputer.com>
1 parent 4ae4cfc commit 80e9922

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

tools/install_builder_prerequisites.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ function install_packages {
142142
packages=(
143143
"pkg:/package/pkg"
144144
"build-essential"
145+
"cmake"
145146
"library/postgresql-$PGVER"
146147
"pkg-config"
147148
"library/libxmlsec1"

0 commit comments

Comments
 (0)