[sled-agent] Read boot partition of M.2 drives (PR 1/2) (#8450)

This PR is basically just adding the `host_phase_2` module to
`sled-agent-config-reconciler`, which reads the boot partition of the
two M.2 slots (using multiple-of-the-disk-block-size reads, which are
required when accessing the raw device). The results of these reads is
only logged as of this PR; the followup adds it to inventory.

There are a handful of other cleanup changes that snuck in here due to
dropping an out-of-date `#![allow(dead_code)]`.

Author: jgallagher

Cargo.lock

@@ -10,6 +10,7 @@ workspace = true
 [dependencies]
 anyhow.workspace = true
 async-trait.workspace = true
+bytes.workspace = true
 camino.workspace = true
 camino-tempfile.workspace = true
 chrono.workspace = true
@@ -27,6 +28,7 @@ nexus-sled-agent-shared.workspace = true
 omicron-common.workspace = true
 omicron-uuid-kinds.workspace = true
 serde.workspace = true
+sha2.workspace = true
 sled-agent-api.workspace = true
 sled-agent-types.workspace = true
 sled-hardware.workspace = true

sled-agent/config-reconciler/Cargo.toml

@@ -0,0 +1,7 @@
+# Seeds for failure cases proptest has generated in the past. It is
+# automatically read and these particular cases re-run before any
+# novel cases are generated.
+#
+# It is recommended to check this file in to source control so that
+# everyone who runs the test benefits from these saved cases.
+cc dae3bb9081ff9f94d9c588fb2d535df1ef72b8af5169dc8bc5072ee99e6ee72b # shrinks to input = _ProptestReadValidHostPhase2Args { data: [], block_size: 512 }

sled-agent/config-reconciler/proptest-regressions/host_phase_2.txt

@@ -180,7 +180,7 @@ pub(crate) struct DatasetTaskHandle(mpsc::Sender<DatasetTaskRequest>);
 impl DatasetTaskHandle {
     // For testing, create a handle on which requests will always fail with a
     // `DatasetTaskError`.
-    #[cfg(any(test, feature = "testing"))]
+    #[cfg(test)]
     pub(crate) fn spawn_noop() -> Self {
         let (tx, _rx) = mpsc::channel(1);
         Self(tx)

sled-agent/config-reconciler/src/dataset_serialization_task.rs

@@ -242,6 +242,7 @@ impl ConfigReconcilerHandle {
             current_config_rx,
             reconciler_result_tx,
             currently_managed_zpools_tx,
+            self.internal_disks_rx.clone(),
             external_disks_tx,
             raw_disks_rx,
             Arc::clone(&self.destroy_orphans),
@@ -420,16 +421,6 @@ impl ConfigReconcilerHandle {
     }
 }
 
-#[derive(Debug)]
-struct ReconcilerTaskDependencies {
-    key_requester: StorageKeyRequester,
-    time_sync_config: TimeSyncConfig,
-    reconciler_result_tx: watch::Sender<ReconcilerResult>,
-    currently_managed_zpools_tx: watch::Sender<Arc<CurrentlyManagedZpools>>,
-    ledger_task_log: Logger,
-    reconciler_task_log: Logger,
-}
-
 /// Fields of sled-agent inventory reported by the config reconciler subsystem.
 ///
 /// Note that much like inventory in general, these fields are not collected