Avoid potential stale version with Octane

[kichetof]

Hello,

Thanks for this great package that I use for many years!

Sometime, it's seem that my audits was not saved (with Octane/FrankenPHP, Laravel from 10-12, laravel-auditing v14) and I try to figure out where issue come.
After digging into the code, Auditor class is bound within singleton that may cause some issue with Octane.

laravel-auditing/src/AuditingServiceProvider.php

Lines 45 to 47 in 177715e

	$this->app->singleton(Auditor::class, function ($app) {
	return new \OwenIt\Auditing\Auditor($app);
	});

As I don't know the side effect to PR this, I start this discussion.

Maybe it will not solve my issue but it'll enhance support with Octane in any case 😄

Possible solutions

Bind doc

$this->app->bind(Auditor::class, function ($app) {
    return new \OwenIt\Auditing\Auditor($app);
});

As a work-around, you could either stop registering the binding as a singleton, or you could inject a container resolver closure into the service that always resolves the current container instance

Scoped doc

$this->app->scoped(Auditor::class, function ($app) {
    return new \OwenIt\Auditing\Auditor($app);
});

instances registered using the scoped method will be flushed whenever the Laravel application starts a new "lifecycle", such as when a Laravel Octane worker processes a new request or when a Laravel queue worker processes a new job:

---

Thanks a lot for your help to dig inside!

[willpower232]

Certainly an interesting problem, particularly when using singleton and injecting the $app seems to be the way laravel wants people to instantiate managers.

Have you tried either or both solutions to see if they work for you?

[kichetof]

Thanks for your reply!

As a work arround, I reduced the octane max-requests to 100 and it seems to avoid any issue. As it really tricky to understand when and why issue happen, I try some modifications to see if issue is solved and go ahead.

I'll push a patch with scoped on production. In local (docker octane + frankenphp), scoped and bind seem to works without issue with the package.