Skip to content

preliminary support for "make dist" target #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

defanator
Copy link
Contributor

The commits in this request make able to use "make dist" target in order to create archive with libmodsecurity sources that can be used later without "./build.sh" step.

There are still some unresolved things like the "BUILT_SOURCES" defined in the src/Makefile.am which doesn't work: the seclang-parser.cc and seclang-scanner.cc files are coming to the final distdir regardless of the "BUILT_SOURCES" value (I have also tried things like "nodist_*" for those files, but had no luck). I.e., in the source tree extracted from the archive generated by "make dist" command, you have to run "make clean" before "make" in order to get all the things done.

@zimmerle
Copy link
Contributor

Hi @defanator,

Thank you for the patch! :)

We may want to run flex and bison before create the .tar.gz but that is a good starting point!

Thank you. It is merged already.

@zimmerle zimmerle closed this Jul 11, 2016
@defanator defanator deleted the libmodsecurity-defanator-20160706 branch July 26, 2016 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants