Skip to content

fix verify_cc.cc init() operator #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

fix verify_cc.cc init() operator #1179

wants to merge 12 commits into from

Conversation

phantom-az
Copy link
Contributor

Alexey Zelkin added 12 commits June 15, 2016 16:10
…e fixes SIGILLs on executable built with clang 3.4.

Tested against FreeBSD 10.3.
For some reason plain call to "ret.append(&b)" copy 32 bit of data.  This change unbreaks
CmdLine unit tests for FreeBSD 10, CentOS 7, RHEL 7 and Debian 8.
Previous versions of bison proven to generate broken code which caused to assert() regression
tests of libmodsecurity for clang 3.4 and gcc 4.8.  Upgrading bison to 3.0.4 solved mentioned issues
for FreeBSD 10, CentOS 7, RHEL 7 and Ubuntu 14.
C++ regex library proven to be unusable for gcc 4.8 and earlier version, so
reimplement code using PCRE library in order to build workable version of
unit_test executable for CentOS 7, RHEL 7, Ubuntu 14 and SUSE Linux 12.
… of std C++ regex library.

C++ regex library proven to be unusable for gcc 4.8 and earlier version, so
reimplement code using PCRE library in order to build workable version of
unit_test executable for CentOS 7, RHEL 7, Ubuntu 14 and SUSE Linux 12.
Unbreaks runtime for FreeBSD 10 (clang generated code)
return value and errptr are NULLs, it means that pcre_study() does not
make sense, so can be ignored.
@zimmerle
Copy link
Contributor

zimmerle commented Jul 5, 2016

Merged. thanks!

@zimmerle zimmerle closed this Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants