Skip to content

Add missing 'retrun's for functions declared return value. #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Add missing 'retrun's for functions declared return value. #1163

wants to merge 4 commits into from

Conversation

phantom-az
Copy link
Contributor

This change fixes SIGILLs on executables built with clang 3.4.

Tested against FreeBSD 10.3.

Alexey Zelkin added 2 commits June 15, 2016 16:10
…e fixes SIGILLs on executable built with clang 3.4.

Tested against FreeBSD 10.3.
For some reason plain call to "ret.append(&b)" copy 32 bit of data.  This change unbreaks
CmdLine unit tests for FreeBSD 10, CentOS 7, RHEL 7 and Debian 8.
@zimmerle
Copy link
Contributor

Hi @phantom-az,

Thank you for the patches.

Alexey Zelkin added 2 commits June 15, 2016 16:32
Previous versions of bison proven to generate broken code which caused to assert() regression
tests of libmodsecurity for clang 3.4 and gcc 4.8.  Upgrading bison to 3.0.4 solved mentioned issues
for FreeBSD 10, CentOS 7, RHEL 7 and Ubuntu 14.
C++ regex library proven to be unusable for gcc 4.8 and earlier version, so
reimplement code using PCRE library in order to build workable version of
unit_test executable for CentOS 7, RHEL 7, Ubuntu 14 and SUSE Linux 12.
@zimmerle
Copy link
Contributor

I've merged the commits:

Thanks!

@zimmerle zimmerle closed this Jun 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants