Skip to content

Commit fd67c6e

Browse files
committed
Remove unneeded heap allocation in AnchoredSetVariable::set
1 parent dc6cce5 commit fd67c6e

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

src/anchored_set_variable.cc

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,7 @@ void AnchoredSetVariable::unset() {
5353
void AnchoredSetVariable::set(const std::string &key,
5454
const std::string &value, size_t offset, size_t len) {
5555
std::unique_ptr<VariableOrigin> origin(new VariableOrigin());
56-
std::string *v = new std::string(value);
57-
VariableValue *var = new VariableValue(&m_name, &key, v);
58-
delete v;
56+
VariableValue *var = new VariableValue(&m_name, &key, &value);
5957

6058
origin->m_offset = offset;
6159
origin->m_length = len;
@@ -68,9 +66,7 @@ void AnchoredSetVariable::set(const std::string &key,
6866
void AnchoredSetVariable::set(const std::string &key,
6967
const std::string &value, size_t offset) {
7068
std::unique_ptr<VariableOrigin> origin(new VariableOrigin());
71-
std::string *v = new std::string(value);
72-
VariableValue *var = new VariableValue(&m_name, &key, v);
73-
delete v;
69+
VariableValue *var = new VariableValue(&m_name, &key, &value);
7470

7571
origin->m_offset = offset;
7672
origin->m_length = value.size();

0 commit comments

Comments
 (0)