Removes unecessary static methods from regex class

zimmerle · zimmerle · commit f96c04d92021 · 2019-01-18T18:24:26.000-03:00
diff --git a/src/anchored_set_variable.cc b/src/anchored_set_variable.cc
@@ -127,7 +127,7 @@ std::unique_ptr<std::string> AnchoredSetVariable::resolveFirst(
 void AnchoredSetVariable::resolveRegularExpression(regex::Regex *r,
     std::vector<const VariableValue *> *l) {
     for (const auto& x : *this) {
-        int ret = regex::regex_search(x.first, *r);
+        int ret = r->search(x.first);
         if (ret <= 0) {
             continue;
         }
@@ -140,7 +140,7 @@ void AnchoredSetVariable::resolveRegularExpression(regex::Regex *r,
     std::vector<const VariableValue *> *l,
     Variables::KeyExclusions &ke) {
     for (const auto& x : *this) {
-        int ret = regex::regex_search(x.first, *r);
+        int ret = r->search(x.first);
         if (ret <= 0) {
             continue;
         }
diff --git a/src/audit_log/audit_log.cc b/src/audit_log/audit_log.cc
@@ -279,8 +279,7 @@ bool AuditLog::isRelevant(int status) {
         return true;
     }
 
-    return regex::regex_search(sstatus,
-        regex::Regex(m_relevant)) != 0;
+    return regex::Regex(m_relevant).search(sstatus) != 0;
 }
 
 
diff --git a/src/collection/backend/in_memory-per_process.cc b/src/collection/backend/in_memory-per_process.cc
@@ -148,7 +148,7 @@ void InMemoryPerProcess::resolveRegularExpression(const std::string& var,
         //}
         //std::string content = std::string(x.first, keySize + 1,
          //                                 x.first.size() - keySize - 1);
-        int ret = regex::regex_search(x.first, r);
+        int ret = r.search(x.first);
         if (ret <= 0) {
             continue;
         }
diff --git a/src/collection/backend/lmdb.cc b/src/collection/backend/lmdb.cc
@@ -560,7 +560,7 @@ void LMDB::resolveRegularExpression(const std::string& var,
 
     while ((rc = mdb_cursor_get(cursor, &key, &data, MDB_NEXT)) == 0) {
         char *a = reinterpret_cast<char *>(key.mv_data);
-        int ret = regex::regex_search(a, r);
+        int ret = r.search(a);
         if (ret <= 0) {
             continue;
         }
diff --git a/src/operators/rx.h b/src/operators/rx.h
@@ -27,7 +27,6 @@
 
 namespace modsecurity {
 using regex::RegexMatch;
-using regex::regex_search;
 using regex::Regex;
 
 namespace operators {
diff --git a/src/operators/verify_cpf.h b/src/operators/verify_cpf.h
@@ -26,7 +26,6 @@
 
 namespace modsecurity {
 using regex::RegexMatch;
-using regex::regex_search;
 using regex::Regex;
 
 namespace operators {
diff --git a/src/operators/verify_ssn.h b/src/operators/verify_ssn.h
@@ -26,7 +26,6 @@
 
 namespace modsecurity {
 using regex::RegexMatch;
-using regex::regex_search;
 using regex::Regex;
 
 namespace operators {
diff --git a/src/regex/regex.h b/src/regex/regex.h
@@ -69,16 +69,6 @@ class Regex {
 };
 
 
-static inline int regex_search(const std::string& s, RegexMatch *match, const Regex& regex) {
-    return regex.search(s, match);
-}
-
-
-static inline int regex_search(const std::string& s, const Regex& regex) {
-    return regex.search(s);
-}
-
-
 }  // namespace regex
 }  // namespace modsecurity
 
diff --git a/src/variables/rule.h b/src/variables/rule.h
@@ -198,23 +198,23 @@ class Rule_DictElementRegexp : public VariableRegex {
     void evaluate(Transaction *t,
         Rule *rule,
         std::vector<const VariableValue *> *l) override {
-        if (regex::regex_search("id", m_r) > 0) {
+        if (m_r.search("id") > 0) {
             Rule_DictElement::id(t, rule, l);
             return;
         }
-        if (regex::regex_search("rev", m_r) > 0) {
+        if (m_r.search("rev") > 0) {
             Rule_DictElement::rev(t, rule, l);
             return;
         }
-        if (regex::regex_search("severity", m_r) > 0) {
+        if (m_r.search("severity") > 0) {
             Rule_DictElement::severity(t, rule, l);
             return;
         }
-        if (regex::regex_search("logdata", m_r) > 0) {
+        if (m_r.search("logdata") > 0) {
             Rule_DictElement::logData(t, rule, l);
             return;
         }
-        if (regex::regex_search("msg", m_r) > 0) {
+        if (m_r.search("msg") > 0) {
             Rule_DictElement::msg(t, rule, l);
             return;
         }
diff --git a/test/regression/custom_debug_log.cc b/test/regression/custom_debug_log.cc
@@ -39,7 +39,7 @@ void CustomDebugLog::write(int level, const std::string &id,
 bool CustomDebugLog::contains(const std::string& pattern) {
     modsecurity::regex::Regex re(pattern);
     std::string s = m_log.str();
-    return modsecurity::regex::regex_search(s, re);
+    return re.search(s);
 }
 
 std::string CustomDebugLog::log_messages() {
diff --git a/test/regression/regression.cc b/test/regression/regression.cc
@@ -37,7 +37,6 @@ using modsecurity_test::ModSecurityTestResults;
 using modsecurity_test::RegressionTest;
 using modsecurity_test::RegressionTestResult;
 
-using modsecurity::regex::regex_search;
 using modsecurity::regex::RegexMatch;
 using modsecurity::regex::Regex;
 
@@ -53,7 +52,7 @@ void print_help() {
 bool contains(const std::string &s, const std::string &pattern) {
     bool ret;
     modsecurity::regex::Regex re(pattern);
-    ret = modsecurity::regex::regex_search(s, re);
+    ret = re.search(s);
     return ret;
 }
 
@@ -202,7 +201,7 @@ void perform_unit_test(ModSecurityTest<RegressionTest> *test,
             RegexMatch match;
             std::string s = modsec_rules->getParserError();
 
-            if (regex_search(s, &match, re)) {
+            if (re.search(s, &match)) {
                 if (test->m_automake_output) {
                     std::cout << ":test-result: PASS " << filename \
                         << ":" << t->name << std::endl;
diff --git a/test/unit/unit_test.cc b/test/unit/unit_test.cc
@@ -62,15 +62,15 @@ void json2bin(std::string *str) {
     modsecurity::regex::Regex re2("\\\\u([a-z0-9A-Z]{4})");
     modsecurity::regex::RegexMatch match;
 
-    while (modsecurity::regex::regex_search(*str, &match, re)) {
+    while (re.search(*str, &match)) {
         unsigned int p;
         std::string toBeReplaced = match.str();
         toBeReplaced.erase(0, 2);
         sscanf(toBeReplaced.c_str(), "%x", &p);
         replaceAll(str, match.str(), p);
     }
 
-    while (modsecurity::regex::regex_search(*str, &match, re2)) {
+    while (re2.search(*str, &match)) {
         unsigned int p;
         std::string toBeReplaced = match.str();
         toBeReplaced.erase(0, 2);

Original file line number	Diff line number	Diff line change
`@@ -279,8 +279,7 @@ bool AuditLog::isRelevant(int status) {`
`279`	`279`	`return true;`
`280`	`280`	`}`
`281`	`281`
`282`		`- return regex::regex_search(sstatus,`
`283`		`- regex::Regex(m_relevant)) != 0;`
	`282`	`+ return regex::Regex(m_relevant).search(sstatus) != 0;`
`284`	`283`	`}`
`285`	`284`
`286`	`285`
Original file line number	Diff line number	Diff line change
`@@ -148,7 +148,7 @@ void InMemoryPerProcess::resolveRegularExpression(const std::string& var,`
`148`	`148`	`//}`
`149`	`149`	`//std::string content = std::string(x.first, keySize + 1,`
`150`	`150`	`// x.first.size() - keySize - 1);`
`151`		`- int ret = regex::regex_search(x.first, r);`
	`151`	`+ int ret = r.search(x.first);`
`152`	`152`	`if (ret <= 0) {`
`153`	`153`	`continue;`
`154`	`154`	`}`
Original file line number	Diff line number	Diff line change
`@@ -560,7 +560,7 @@ void LMDB::resolveRegularExpression(const std::string& var,`
`560`	`560`
`561`	`561`	`while ((rc = mdb_cursor_get(cursor, &key, &data, MDB_NEXT)) == 0) {`
`562`	`562`	`char a = reinterpret_cast<char >(key.mv_data);`
`563`		`- int ret = regex::regex_search(a, r);`
	`563`	`+ int ret = r.search(a);`
`564`	`564`	`if (ret <= 0) {`
`565`	`565`	`continue;`
`566`	`566`	`}`
Original file line number	Diff line number	Diff line change
`@@ -198,23 +198,23 @@ class Rule_DictElementRegexp : public VariableRegex {`
`198`	`198`	`void evaluate(Transaction *t,`
`199`	`199`	`Rule *rule,`
`200`	`200`	`std::vector<const VariableValue > l) override {`
`201`		`- if (regex::regex_search("id", m_r) > 0) {`
	`201`	`+ if (m_r.search("id") > 0) {`
`202`	`202`	`Rule_DictElement::id(t, rule, l);`
`203`	`203`	`return;`
`204`	`204`	`}`
`205`		`- if (regex::regex_search("rev", m_r) > 0) {`
	`205`	`+ if (m_r.search("rev") > 0) {`
`206`	`206`	`Rule_DictElement::rev(t, rule, l);`
`207`	`207`	`return;`
`208`	`208`	`}`
`209`		`- if (regex::regex_search("severity", m_r) > 0) {`
	`209`	`+ if (m_r.search("severity") > 0) {`
`210`	`210`	`Rule_DictElement::severity(t, rule, l);`
`211`	`211`	`return;`
`212`	`212`	`}`
`213`		`- if (regex::regex_search("logdata", m_r) > 0) {`
	`213`	`+ if (m_r.search("logdata") > 0) {`
`214`	`214`	`Rule_DictElement::logData(t, rule, l);`
`215`	`215`	`return;`
`216`	`216`	`}`
`217`		`- if (regex::regex_search("msg", m_r) > 0) {`
	`217`	`+ if (m_r.search("msg") > 0) {`
`218`	`218`	`Rule_DictElement::msg(t, rule, l);`
`219`	`219`	`return;`
`220`	`220`	`}`
Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ void CustomDebugLog::write(int level, const std::string &id,`
`39`	`39`	`bool CustomDebugLog::contains(const std::string& pattern) {`
`40`	`40`	`modsecurity::regex::Regex re(pattern);`
`41`	`41`	`std::string s = m_log.str();`
`42`		`- return modsecurity::regex::regex_search(s, re);`
	`42`	`+ return re.search(s);`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`std::string CustomDebugLog::log_messages() {`