Skip to content

Commit d434a6c

Browse files
Chaim SandersFelipe Zimmerle
authored andcommitted
Fixing missing return value check for hashing response injection failure
1 parent b3f197d commit d434a6c

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

apache2/apache2_io.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -609,8 +609,12 @@ static int flatten_response_body(modsec_rec *msr) {
609609
retval = hash_response_body_links(msr);
610610
if(retval > 0) {
611611
retval = inject_hashed_response_body(msr, retval);
612-
if (msr->txcfg->debuglog_level >= 4) {
613-
msr_log(msr, 4, "Hash completed in %" APR_TIME_T_FMT " usec.", (apr_time_now() - time1));
612+
if(retval < 0){
613+
msr_log(msr, 1, "inject_hashed_response_body: Unable to inject hash into response body. Returning response without changes." );
614+
}else{
615+
if (msr->txcfg->debuglog_level >= 4) {
616+
msr_log(msr, 4, "Hash completed in %" APR_TIME_T_FMT " usec.", (apr_time_now() - time1));
617+
}
614618
}
615619

616620
}

0 commit comments

Comments
 (0)