Skip to content

Commit cd2dded

Browse files
committed
Removed unnecessary break after return
1 parent 0cd2f45 commit cd2dded

File tree

2 files changed

+0
-6
lines changed

2 files changed

+0
-6
lines changed

src/operators/validate_utf8_encoding.cc

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,6 @@ bool ValidateUtf8Encoding::evaluate(Transaction *transaction, RuleWithActions *r
132132
std::to_string(i) + "\"]");
133133
}
134134
return true;
135-
break;
136135
case UNICODE_ERROR_INVALID_ENCODING :
137136
if (transaction) {
138137
ms_dbg_a(transaction, 8, "Invalid UTF-8 encoding: "
@@ -142,7 +141,6 @@ bool ValidateUtf8Encoding::evaluate(Transaction *transaction, RuleWithActions *r
142141
logOffset(ruleMessage, i, str.size());
143142
}
144143
return true;
145-
break;
146144
case UNICODE_ERROR_OVERLONG_CHARACTER :
147145
if (transaction) {
148146
ms_dbg_a(transaction, 8, "Invalid UTF-8 encoding: "
@@ -152,7 +150,6 @@ bool ValidateUtf8Encoding::evaluate(Transaction *transaction, RuleWithActions *r
152150
logOffset(ruleMessage, i, str.size());
153151
}
154152
return true;
155-
break;
156153
case UNICODE_ERROR_RESTRICTED_CHARACTER :
157154
if (transaction) {
158155
ms_dbg_a(transaction, 8, "Invalid UTF-8 encoding: "
@@ -162,7 +159,6 @@ bool ValidateUtf8Encoding::evaluate(Transaction *transaction, RuleWithActions *r
162159
logOffset(ruleMessage, i, str.size());
163160
}
164161
return true;
165-
break;
166162
case UNICODE_ERROR_DECODING_ERROR :
167163
if (transaction) {
168164
ms_dbg_a(transaction, 8, "Error validating UTF-8 decoding "
@@ -171,7 +167,6 @@ bool ValidateUtf8Encoding::evaluate(Transaction *transaction, RuleWithActions *r
171167
logOffset(ruleMessage, i, str.size());
172168
}
173169
return true;
174-
break;
175170
}
176171

177172
if (rc <= 0) {

test/cppcheck_suppressions.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ functionStatic:src/engine/lua.h:71
4444
functionConst:src/utils/geo_lookup.h:49
4545
useInitializationList:src/operators/rbl.h:69
4646
functionStatic:src/operators/geo_lookup.h:35
47-
duplicateBreak:src/operators/validate_utf8_encoding.cc
4847
syntaxError:src/transaction.cc:62
4948
noConstructor:src/variables/variable.h:152
5049
knownConditionTrueFalse:src/operators/validate_url_encoding.cc:77

0 commit comments

Comments
 (0)