Skip to content

Commit ca99ccd

Browse files
committed
Fix unexpected behavior if the XML tag is empty
1 parent c01e5db commit ca99ccd

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

apache2/msc_xml.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,14 +85,14 @@ static void msc_xml_on_end_elementns(
8585

8686
arg->name = xml_parser_state->currpath;
8787
arg->name_len = strlen(arg->name);
88-
arg->value = xml_parser_state->currval;
89-
arg->value_len = strlen(xml_parser_state->currval);
88+
arg->value = (xml_parser_state->currval == NULL) ? apr_pstrndup(msr->mp, "", 1) : xml_parser_state->currval;
89+
arg->value_len = (xml_parser_state->currval == NULL) ? 0 : strlen(xml_parser_state->currval);
9090
arg->value_origin_len = arg->value_len;
9191
arg->origin = "XML";
9292

9393
if (msr->txcfg->debuglog_level >= 9) {
9494
msr_log(msr, 9, "Adding XML argument '%s' with value '%s'",
95-
xml_parser_state->currpath, xml_parser_state->currval);
95+
xml_parser_state->currpath, arg->value);
9696
}
9797

9898
apr_table_addn(msr->arguments,

0 commit comments

Comments
 (0)