Skip to content

Commit 89f5427

Browse files
author
Felipe Zimmerle
committed
potential off by one in parse_arguments
Issue: #1799
1 parent fecc429 commit 89f5427

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

CHANGES

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
DD MMM YYYY - 2.9.3 - To be released
22
------------------------------------
3-
3+
* potential off by one in parse_arguments
4+
[Issue #1799 - @tinselcity, @zimmerle]
45
* Fix utf-8 character encoding conversion
56
[Issue #1794 - @tinselcity, @zimmerle]
67
* Fix ip tree lookup on netmask content

apache2/msc_parsers.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ int parse_arguments(modsec_rec *msr, const char *s, apr_size_t inputlength,
266266
if (status == 0) {
267267
/* parameter name */
268268
arg->name_origin_offset = i;
269-
while ((s[i] != '=') && (s[i] != argument_separator) && (i < inputlength)) {
269+
while ((i < inputlength) && (s[i] != '=') && (s[i] != argument_separator)) {
270270
buf[j] = s[i];
271271
j++;
272272
i++;

0 commit comments

Comments
 (0)