Revert "Double memory allocation"

airween · web-flow · commit 5cbd7e6e6c9c · 2024-02-07T23:09:59.000+01:00
diff --git a/apache2/re.c b/apache2/re.c
@@ -499,7 +499,7 @@ char *update_rule_target_ex(modsec_rec *msr, msre_ruleset *ruleset, msre_rule *r
         if(var_appended == 1)  {
             current_targets = msre_generate_target_string(ruleset->mp, rule);
             rule->unparsed = msre_rule_generate_unparsed(ruleset->mp, rule, current_targets, NULL, NULL);
-            rule->p1 = current_targets;
+            rule->p1 = apr_pstrdup(ruleset->mp, current_targets);
             if(msr) {
                 msr_log(msr, 9, "Successfully appended variable");
             }

Original file line number	Diff line number	Diff line change
`@@ -499,7 +499,7 @@ char update_rule_target_ex(modsec_rec msr, msre_ruleset ruleset, msre_rule r`
`499`	`499`	`if(var_appended == 1) {`
`500`	`500`	`current_targets = msre_generate_target_string(ruleset->mp, rule);`
`501`	`501`	`rule->unparsed = msre_rule_generate_unparsed(ruleset->mp, rule, current_targets, NULL, NULL);`
`502`		`- rule->p1 = current_targets;`
	`502`	`+ rule->p1 = apr_pstrdup(ruleset->mp, current_targets);`
`503`	`503`	`if(msr) {`
`504`	`504`	`msr_log(msr, 9, "Successfully appended variable");`
`505`	`505`	`}`