Skip to content

Commit 4b39183

Browse files
author
Marc Stern
committed
added more NULL checks at run-time
1 parent 0066a67 commit 4b39183

File tree

1 file changed

+13
-0
lines changed

1 file changed

+13
-0
lines changed

apache2/apache2_config.c

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3141,6 +3141,10 @@ static const char *cmd_hash_param(cmd_parms *cmd, void *_dcfg, const char *p1)
31413141
ap_log_perror(APLOG_MARK, APLOG_EMERG, 0, cmd->pool, NULL, "cmd_hash_param: _dcfg is NULL");
31423142
return NULL;
31433143
}
3144+
if (p1 == NULL) {
3145+
ap_log_perror(APLOG_MARK, APLOG_EMERG, 0, cmd->pool, NULL, "cmd_hash_param: p1 is NULL");
3146+
return NULL;
3147+
}
31443148
directory_config *dcfg = (directory_config *)_dcfg;
31453149

31463150
dcfg->crypto_param_name = p1;
@@ -3173,6 +3177,10 @@ static const char *cmd_hash_key(cmd_parms *cmd, void *_dcfg, const char *_p1, co
31733177
ap_log_perror(APLOG_MARK, APLOG_EMERG, 0, cmd->pool, NULL, "cmd_hash_key: _p1 is NULL");
31743178
return NULL;
31753179
}
3180+
if (_p2 == NULL) {
3181+
ap_log_perror(APLOG_MARK, APLOG_EMERG, 0, cmd->pool, NULL, "cmd_hash_key: _p2 is NULL");
3182+
return NULL;
3183+
}
31763184
directory_config *dcfg = (directory_config *)_dcfg;
31773185
char *p1 = NULL;
31783186

@@ -3533,6 +3541,11 @@ static const char *cmd_unicode_map(cmd_parms *cmd, void *_dcfg,
35333541
assert(cmd != NULL);
35343542
assert(p1 != NULL);
35353543
assert(p2 != NULL);
3544+
// Normally useless code, left to be safe for the moment
3545+
if (_dcfg == NULL) {
3546+
ap_log_perror(APLOG_MARK, APLOG_EMERG, 0, cmd->pool, NULL, "cmd_unicode_map: _dcfg is NULL");
3547+
return NULL;
3548+
}
35363549
const char *filename = resolve_relative_path(cmd->pool, cmd->directive->filename, p1);
35373550
char *error_msg;
35383551
long val = 0;

0 commit comments

Comments
 (0)