Return false in SharedFiles::open() when an error happens

Author: Wenfeng Liu

src/utils/shared_files.cc

@@ -127,6 +127,7 @@ std::pair<msc_file_handler *, FILE *> SharedFiles::add_new_handler(
 
 bool SharedFiles::open(const std::string& fileName, std::string *error) {
     std::pair<msc_file_handler *, FILE *> a;
+    bool ret = true;
 
     #if MODSEC_USE_GENERAL_LOCK
     pthread_mutex_lock(m_generalLock);
@@ -136,11 +137,13 @@ bool SharedFiles::open(const std::string& fileName, std::string *error) {
     if (a.first == NULL) {
         a = add_new_handler(fileName, error);
         if (error->size() > 0) {
+            ret = false;
             goto out;
         }
     }
     if (a.first == NULL) {
         error->assign("Not able to open: " + fileName);
+        ret = false;
         goto out;
     }
 
@@ -149,7 +152,7 @@ bool SharedFiles::open(const std::string& fileName, std::string *error) {
     pthread_mutex_unlock(m_generalLock);
 #endif
 
-    return true;
+    return ret;
 }