Skip to content

Commit 199a9db

Browse files
martinhsvzimmerle
authored andcommitted
Fix nolog rules logging to part H
1 parent 9cac167 commit 199a9db

File tree

2 files changed

+3
-10
lines changed

2 files changed

+3
-10
lines changed

CHANGES

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
v3.0.4 - YYYY-MMM-DD (to be released)
22
-------------------------------------
33

4+
- Fix rules with nolog are logging to part H
5+
[Issue #2196 - @martinhsv]
46
- Fix argument key-value pair parsing cases
57
[Issue #1904 - @martinhsv]
68
- Fix: audit log part for response body for JSON format to be E

src/rule.cc

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -802,8 +802,7 @@ bool Rule::evaluate(Transaction *trans,
802802

803803
/* last rule in the chain. */
804804
bool isItToBeLogged = ruleMessage->m_saveMessage;
805-
if (isItToBeLogged && !m_containsMultiMatchAction
806-
&& !ruleMessage->m_message.empty()) {
805+
if (isItToBeLogged && !m_containsMultiMatchAction) {
807806
/* warn */
808807
trans->m_rulesMessages.push_back(*ruleMessage);
809808

@@ -812,14 +811,6 @@ bool Rule::evaluate(Transaction *trans,
812811
trans->serverLog(ruleMessage);
813812
}
814813
}
815-
else if (!m_containsMultiMatchAction) {
816-
/* warn */
817-
trans->m_rulesMessages.push_back(*ruleMessage);
818-
/* error */
819-
if (!ruleMessage->m_isDisruptive) {
820-
trans->serverLog(ruleMessage);
821-
}
822-
}
823814

824815
return true;
825816
}

0 commit comments

Comments
 (0)