Skip to content

Commit cab9622

Browse files
authored
feat(ui): use new all tasks filter for both admin and non admin (#243)
Signed-off-by: richardlt <richard.le.terrier@gmail.com>
1 parent 3d48577 commit cab9622

File tree

3 files changed

+6
-24
lines changed

3 files changed

+6
-24
lines changed

ui/dashboard/projects/utask-lib/src/lib/@components/tasks-list/tasks-list.component.ts

Lines changed: 4 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -268,26 +268,10 @@ export class TasksListComponent implements OnInit, OnDestroy, OnChanges, AfterVi
268268
}
269269

270270
loadTasks(paramLast: string = ''): Observable<Array<Task>> {
271-
// Trick to get both own and resolvable task for non admin user
272-
// We ignore the last param for resolvable tasks so we will only get the first ones
273-
if (this.params.type === TaskType.both) {
274-
return forkJoin({
275-
resolvable: this._api.task.list({
276-
...this.params,
277-
type: TaskType.resolvable
278-
}),
279-
own: this._api.task.list({
280-
...this.params,
281-
type: TaskType.own,
282-
last: paramLast
283-
})
284-
}).pipe(map(r => r.own.body.concat(r.resolvable.body)));
285-
} else {
286-
return this._api.task.list({
287-
...this.params,
288-
last: paramLast
289-
}).pipe(map(res => res.body));
290-
}
271+
return this._api.task.list({
272+
...this.params,
273+
last: paramLast
274+
}).pipe(map(res => res.body));
291275
}
292276

293277
clickShowMore(): void {

ui/dashboard/projects/utask-lib/src/lib/@models/task.model.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ export class ResolutionStep {
2424
export enum TaskType {
2525
all = 'all',
2626
own = 'own',
27-
both = 'both',
2827
resolvable = 'resolvable'
2928
};
3029

ui/dashboard/projects/utask-lib/src/lib/@routes/tasks/tasks.component.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,11 +82,10 @@ export class TasksComponent implements OnInit {
8282
const params = new ParamsListTasks();
8383
const pageSize = parseInt(queryParams.page_size, 10)
8484
params.page_size = pageSize && 10 <= pageSize && pageSize <= 1000 ? pageSize : 10;
85-
const defaultType = this.meta.user_is_admin ? TaskType.all : TaskType.both;
86-
params.type = queryParams.type || defaultType;
85+
params.type = queryParams.type || TaskType.all;
8786
params.last = '';
8887
params.state = queryParams.state || '';
89-
params.template = queryParams.template || '';
88+
params.template = queryParams.template || '';
9089
params.tag = queryParams.tag ? JSON.parse(queryParams.tag) : [];
9190
return params;
9291
}

0 commit comments

Comments
 (0)