Fix parent elements in config XML files not closing in a new line

ousnius · ousnius · commit 50a291a686a6 · 2024-10-05T22:56:21.000+02:00
diff --git a/src/utils/ConfigurationManager.cpp b/src/utils/ConfigurationManager.cpp
@@ -78,8 +78,10 @@ void ConfigurationItem::ToXML(XMLElement* elem) {
 			child->ToXML(element);
 	}
 
-	XMLText* newText = elem->GetDocument()->NewText(value.c_str());
-	element->InsertEndChild(newText);
+	if (children.empty() || !value.empty()) {
+		XMLText* newText = elem->GetDocument()->NewText(value.c_str());
+		element->InsertEndChild(newText);
+	}
 }
 
 int ConfigurationItem::EnumerateProperties(std::vector<ConfigurationItem*>& outList) {

Original file line number	Diff line number	Diff line change
`@@ -78,8 +78,10 @@ void ConfigurationItem::ToXML(XMLElement* elem) {`
`78`	`78`	`child->ToXML(element);`
`79`	`79`	`}`
`80`	`80`
`81`		`- XMLText* newText = elem->GetDocument()->NewText(value.c_str());`
`82`		`- element->InsertEndChild(newText);`
	`81`	`+ if (children.empty() \|\| !value.empty()) {`
	`82`	`+ XMLText* newText = elem->GetDocument()->NewText(value.c_str());`
	`83`	`+ element->InsertEndChild(newText);`
	`84`	`+ }`
`83`	`85`	`}`
`84`	`86`
`85`	`87`	`int ConfigurationItem::EnumerateProperties(std::vector<ConfigurationItem*>& outList) {`