You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As @pzx601917159 suggested, SRS can use the clang-format tool to format the code, so we don't need to review the coding style in Pull Requests.
Thanks to @chen-guanghua for submitting a Pull Request to support clang-format. See #4366 for details. I have merged this Pull Request.
It will significantly change SRS, which will cause existing Pull Requests to conflict with the develop branch. So I merged this Pull Request but didn't apply the tool to all the code to avoid widespread conflicts.
I also created a no-clang-format branch for those who prefer the coding style without clang-format. Existing PRs can be compared to this branch.
I plan to apply the clang-format tool after the two huge Pull Requests, #4333 and #4349, are merged to minimize conflicts. Then I will merge #4367 and apply the clang-format tool in our workflow by default.
Thanks to everyone who contributed to this idea and implementation!
EnglishNativeThis issue is conveyed exclusively in English.
1 participant
Heading
Bold
Italic
Quote
Code
Link
Numbered list
Unordered list
Task list
Attach files
Mention
Reference
Menu
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
As @pzx601917159 suggested, SRS can use the clang-format tool to format the code, so we don't need to review the coding style in Pull Requests.
Thanks to @chen-guanghua for submitting a Pull Request to support clang-format. See #4366 for details. I have merged this Pull Request.
It will significantly change SRS, which will cause existing Pull Requests to conflict with the develop branch. So I merged this Pull Request but didn't apply the tool to all the code to avoid widespread conflicts.
I also created a no-clang-format branch for those who prefer the coding style without
clang-format
. Existing PRs can be compared to this branch.I plan to apply the
clang-format
tool after the two huge Pull Requests, #4333 and #4349, are merged to minimize conflicts. Then I will merge #4367 and apply theclang-format
tool in our workflow by default.Thanks to everyone who contributed to this idea and implementation!
Beta Was this translation helpful? Give feedback.
All reactions