Skip to content

CITest evaluation documentation inconsistent with implementation #3616

@AdamKorcz

Description

@AdamKorcz

Describe the bug
The CITest evaluation has inconsistencies between documentation and implemention.

The documentation says:

This check tries to determine if the project runs tests before pull requests are merged. It is currently limited to repositories hosted on GitHub, and does not support other source hosting repositories (i.e., Forges).

However, the implementation only considers succesful CI runs:

for _, cr := range r.CheckRuns {
if cr.Status != "completed" {
continue
}
if cr.Conclusion != success {
continue
}

if status.State != success {
continue
}

As such, projects that do run tests in their CI will fulfil the requirement specified in the documentation, but they will fail the check.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    Status

    Todo

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions