Build error, incomplete type

[BitPuffin]

Trying to build opensplice with clang on latest OS X.

Getting this error(s):

ld: unknown option: --verbose
In file included from code/dds/domain/DomainParticipantListener.cpp:17:
In file included from include/dds/domain/DomainParticipantListener.hpp:22:
In file included from include/spec/dds/domain/DomainParticipantListener.hpp:22:
In file included from include/dds/pub/PublisherListener.hpp:22:
In file included from include/spec/dds/pub/PublisherListener.hpp:22:
In file included from include/dds/pub/AnyDataWriterListener.hpp:22:
In file included from include/spec/dds/pub/AnyDataWriterListener.hpp:22:
In file included from include/dds/pub/AnyDataWriter.hpp:22:
In file included from include/spec/dds/pub/AnyDataWriter.hpp:25:
In file included from include/dds/pub/detail/AnyDataWriter.hpp:24:
include/dds/pub/DataWriter.hpp:637:33: error: variable has incomplete type 'dds::pub::AnyDataWriter'
        dds::pub::AnyDataWriter adw(*this);
                                ^
include/dds/pub/DataWriter.hpp:34:7: note: forward declaration of 'dds::pub::AnyDataWriter'
class AnyDataWriter;
      ^
include/dds/pub/DataWriter.hpp:651:33: error: variable has incomplete type 'dds::pub::AnyDataWriter'
        dds::pub::AnyDataWriter adr(*this);
                                ^
include/dds/pub/DataWriter.hpp:34:7: note: forward declaration of 'dds::pub::AnyDataWriter'
class AnyDataWriter;
      ^
2 errors generated.
make[8]: *** [.objRelease/code/dds/domain/DomainParticipantListener.o] Error 1
make[7]: *** [Build_DCPS_ISO_Cpp_Lib] Error 2
make[6]: *** [build_isocpp] Error 2
make[5]: *** [dcps.ss_link] Error 2
make[4]: *** [api.ss_link] Error 2
make[3]: *** [src.ss_link] Error 2
In file included from code/dds/domain/DomainParticipantListener.cpp:17:
In file included from include/dds/domain/DomainParticipantListener.hpp:22:
In file included from include/spec/dds/domain/DomainParticipantListener.hpp:22:
In file included from include/dds/pub/PublisherListener.hpp:22:
In file included from include/spec/dds/pub/PublisherListener.hpp:22:
In file included from include/dds/pub/AnyDataWriterListener.hpp:22:
In file included from include/spec/dds/pub/AnyDataWriterListener.hpp:22:
In file included from include/dds/pub/AnyDataWriter.hpp:22:
In file included from include/spec/dds/pub/AnyDataWriter.hpp:25:
In file included from include/dds/pub/detail/AnyDataWriter.hpp:24:
include/dds/pub/DataWriter.hpp:637:33: error: variable has incomplete type 'dds::pub::AnyDataWriter'
        dds::pub::AnyDataWriter adw(*this);
                                ^
include/dds/pub/DataWriter.hpp:34:7: note: forward declaration of 'dds::pub::AnyDataWriter'
class AnyDataWriter;
      ^
include/dds/pub/DataWriter.hpp:651:33: error: variable has incomplete type 'dds::pub::AnyDataWriter'
        dds::pub::AnyDataWriter adr(*this);
                                ^
include/dds/pub/DataWriter.hpp:34:7: note: forward declaration of 'dds::pub::AnyDataWriter'
class AnyDataWriter;
      ^
2 errors generated.
make[8]: *** [.objRelease/code/dds/domain/DomainParticipantListener.o] Error 1
make[7]: *** [Build_DCPS_ISO_Cpp_Lib] Error 2
make[6]: *** [build_isocpp] Error 2
make[5]: *** [dcps.ss_link] Error 2
make[4]: *** [api.ss_link] Error 2
make[3]: *** [src.ss_link] Error 2
+ rm -rf install/minimal
+ mkdir -p install/minimal
+ cp -aL lib/x86_64.darwin10_clang-release install/minimal/lib
+ mkdir -p install/minimal/include
+ cp -a 'install/HDE/*/include' install/minimal/include/opensplice
cp: install/HDE/*/include: No such file or directory
+ mkdir -p install/minimal/etc
+ cp -a 'install/HDE/*/etc' install/minimal/etc/opensplice
cp: install/HDE/*/etc: No such file or directory
+ cp -a 'install/HDE/*/bin' install/minimal
cp: install/HDE/*/bin: No such file or directory
+ mkdir -p install/minimal/share/opensplice/cmake
+ cp opensplice-config.cmake install/minimal/share/opensplice/cmake
+ cd install/minimal
+ tar czf opensplice-minimal.tgz lib include etc bin share
tar: bin: Cannot stat: No such file or directory
tar: Error exit delayed from previous errors.
+ set +x

Not sure how to fix it.

[wjwwood]

What version of OS X? El Capitan? I haven't upgraded yet and I cannot reproduce this on my machine at the moment.

I'll address this when I update (not sure when that will be). Please let us know if you have anymore info on the problem.

[BitPuffin]

Yes this is on El Capitan with XCode 7.0 I believe.

[scpeters]

I just reproduced the failure on my laptop that is running osx 10.11 with the command line tools installed (not full xcode). Here's the full log, and @wjwwood indicated that the following may be the important part:

idlpp -l java -S -d bld/code/x86_64.darwin10_clang-release `ospl_normalizePath /tmp/opensplice20151104-34331-m7fxh3/opensplice/etc/idl/dds_builtinTopics.idl`
dyld: Library not loaded: libddshts.dylib
  Referenced from: /tmp/opensplice20151104-34331-m7fxh3/opensplice/exec/x86_64.darwin10_clang-release/idlpp
  Reason: image not found
make[8]: *** [bld/code/x86_64.darwin10_clang-release/.java_idl.timestamp] Trace/BPT trap: 5
make[7]: *** [saj.ss_link] Error 2
make[6]: *** [java.ss_link] Error 2
make[5]: *** [dcps.ss_link] Error 2
make[4]: *** [api.ss_link] Error 2
make[3]: *** [src.ss_link] Error 2

[wjwwood]

@BitPuffin can you look through your error output to see if you can find a similar snippet?

[BitPuffin]

I tried to the other day, but unless I don't remember correctly anymore, I think it maybe successfully installed after I removed the current apparently partial install of opensplice though I'm not entirely sure. Is there a way to verify with homebrew that a package was installed correctly?

edit: well, as from scratch as git reset --hard HEAD and git clean -fd is

[wjwwood]

@BitPuffin if it appears as installed then it should be good. An aborted install shouldn't show as installed afterwards. You can also remove it and then install it again if you're unsure.

[BitPuffin]

You mean it's all fine as long as I have "install/minimal/opensplice-minimal.tgz"
I kinda feel like the error indicates that some component didn't get built though that might be necessary?

[wjwwood]

@BitPuffin sorry, I thought you were using brew to install it. You may need the patches in the Homebrew formula to build on OS X:

https://github.com/osrf/homebrew-ros2/blob/master/opensplice.rb

[BitPuffin]

Yeah first when I was unable to compile it with brew I tried to do it manually from source in order to be able to better diagnose what was wrong and maybe help fix it.

Either way it should be possible to compile outside of brew I think in order for people on OS X (like me) to be able to contribute to the project.

Rather than having those patches in the brew script, maybe those patches should exist somewhere in the project and be applied by cmake before compiling or something. Or perhaps it should be through conditional compilation.

What do you think?

[wjwwood]

Yeah, it would be nice to not need the patches, I think we added them to the brew formula because that way we didn't chance interfering with Linux or Windows. However, this is supposed to be just a external dependency of ours, and patches that we use in packaging should really be posted upstream to PrismTech/opensplice.

Can you install it with brew? Or you're not using brew?