Skip to content
This repository was archived by the owner on Mar 18, 2025. It is now read-only.
This repository was archived by the owner on Mar 18, 2025. It is now read-only.

Add check to make sure the oscillations of the hydrostatic model are actually sinusoidal. #135

@arjo129

Description

@arjo129

The TEST(Stability, RestoringMoment) unit test only checks the maximum pitch but as @chapulina pointed out:

Should we check minPitch too?

It would also be interesting to check that the vehicle is actually bouncing up and down, because the current test would also pass if the
amplitude is decreasing (which shouldn't happen because we don't have hydrodynamics loaded), or even if the vehicle were stopped in
place. I'm not sure what the quickest way of testing this would be, maybe checking that the pitch rate keeps going up and down?

Original thread here: #89 (comment)

We should try to find a way to check for oscillations.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions