Perhaps installing postgis_raster is not needed with newer Postgres

[umrashrf]

Describe the bug

I had to make a small change to import pbf to postgres.

diff --git a/src/nominatim_db/tools/database_import.py b/src/nominatim_db/tools/database_import.py
index 809a8839..0744d539 100644
--- a/src/nominatim_db/tools/database_import.py
+++ b/src/nominatim_db/tools/database_import.py
@@ -98,7 +98,6 @@ def setup_database_skeleton(dsn: str, rouser: Optional[str] = None) -> None:
         with conn.cursor() as cur:
             cur.execute('CREATE EXTENSION IF NOT EXISTS hstore')
             cur.execute('CREATE EXTENSION IF NOT EXISTS postgis')
-            cur.execute('CREATE EXTENSION IF NOT EXISTS postgis_raster')
 
         conn.commit()

To Reproduce

Software Environment (please complete the following information):

• Nominatim version: master branch
• Postgresql version: 17.5
• Postgis version: 3.5
• OS: mac osx

Hardware Configuration (please complete the following information):

• RAM:
• number of CPUs:
• type and size of disks:

Postgresql Configuration:

Nominatim Configuration:

Additional context

[mtmail]

Afaik the raster library is needed for the secondary importance file. https://nominatim.org/release-docs/latest/admin/Import/#downloading-additional-data

[lonvia]

You need to tell us more about why you made the change: What was the error you got? How did you install Postgresql and Postgis?

[umrashrf]

Sorry yes I should have added the error I was getting.

It was failing to run this line. I don't exactly remember the error but following were the steps.

1. Clone repo and follow the readme
2. source venv/bin/activate
3. brew install postgres@17
4. brew install postgis
5. nominatim import ....

[mtmail]

I see an active discussion on extension library paths, I'd probably require building postgis from source. Homebrew/homebrew-core#224072 We don't officially support MacOS. Did the nominatim import work after your change?

[lonvia]

postgis-raster needs to be explicitly disabled when building postgis and I don't see that being done in the postgis keg file. So no reason it shouldn't be there. What is the exact error you get when running psql -d nominatim -c 'CREATE EXTENSION postgis_raster'?

[lonvia]

@anqixxx I believe you are successfully running Nominatim under MacOS. Can you maybe share how you have set up Postgres+Postgis?

[umrashrf]

Day 3 is starting soon and the import is still running. I'm in no rush I'll wait until it finishes. I'm loading the whole OSM pbf file.

[anqixxx]

Hi! I basically followed the below:

 mkdir nominatim-project
 cd nominatim-project
 ../nominatim-venv/bin/nominatim import --osm-file <your planet file>

Then I installed posrgresql using brew install postgresql. However I did have to fix my permissions for postgresql ( sudo chown -R $(whoami) ~/Library/LaunchAgents). I believe I did a whoami and then it worked (psql -U $(whoami) -d postgres -c "SHOW config_file;").

After that I loaded in my pbf file! I did only import a small fraction of the world though (one city) to do some testing on, so it was way faster for me!

[lonvia]

Okay, so postgis_raster works in principle when installing from homebrew.

Converting this to a discussion and waiting for feedback from @umrashrf .