Skip to content

Commit f87bd8e

Browse files
Fixed indexing issue when slicing provided URLs
1 parent 5c305c4 commit f87bd8e

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

ksqLight/server/server.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ const RootQueryType = new GraphQLObjectType({
6262
prometheusURL: { type: GraphQLNonNull(GraphQLString)}
6363
},
6464
resolve: (parent, {start, end, resolution, metric, prometheusURL}) => {
65-
if (prometheusURL[prometheusURL.length] === '/') prometheusURL = prometheusURL.slice(0, prometheusURL.length - 1);
65+
if (prometheusURL[prometheusURL.length - 1] === '/') prometheusURL = prometheusURL.slice(0, prometheusURL.length - 1);
6666

6767
return axios.get(`${prometheusURL}/api/v1/query_range?step=${resolution}s&end=${end}&start=${start}&query=${queryTypes[metric]}`)
6868
.then(res => {
@@ -141,7 +141,7 @@ const RootQueryType = new GraphQLObjectType({
141141
prometheusURL: { type: GraphQLNonNull(GraphQLString)}
142142
},
143143
resolve: async (parent, { prometheusURL }) => {
144-
if (prometheusURL[prometheusURL.length] === '/') prometheusURL = prometheusURL.slice(0, prometheusURL.length - 1);
144+
if (prometheusURL[prometheusURL.length - 1] === '/') prometheusURL = prometheusURL.slice(0, prometheusURL.length - 1);
145145

146146
return axios.get(`${prometheusURL}/api/v1/status/buildinfo`)
147147
.then(res => ({
@@ -161,7 +161,7 @@ const RootQueryType = new GraphQLObjectType({
161161
ksqlDBURL: { type: GraphQLNonNull(GraphQLString)}
162162
},
163163
resolve: (parent, { ksqlDBURL }) => {
164-
if (ksqlDBURL[ksqlDBURL.length] === '/') ksqlDBURL = ksqlDBURL.slice(0, ksqlDBURL.length - 1);
164+
if (ksqlDBURL[ksqlDBURL.length - 1] === '/') ksqlDBURL = ksqlDBURL.slice(0, ksqlDBURL.length - 1);
165165

166166
return axios.get(`${ksqlDBURL}/clusterStatus`)
167167
.then(res => ({
@@ -185,7 +185,7 @@ const RootQueryType = new GraphQLObjectType({
185185
prometheusURL: { type: GraphQLNonNull(GraphQLString)}
186186
},
187187
resolve: (parent, { start, end, resolution, metric, prometheusURL }) => {
188-
if (prometheusURL[prometheusURL.length] === '/') prometheusURL = prometheusURL.slice(0, prometheusURL.length - 1);
188+
if (prometheusURL[prometheusURL.length - 1] === '/') prometheusURL = prometheusURL.slice(0, prometheusURL.length - 1);
189189

190190

191191
return axios.get(`${prometheusURL}/api/v1/query_range?step=${resolution}s&end=${end}&start=${start}&query=${queryTypes[metric]}`)

0 commit comments

Comments
 (0)