Skip to content

Commit d10e534

Browse files
committed
added comments and fixed docker ksqldb url
1 parent 1779835 commit d10e534

File tree

4 files changed

+7
-2
lines changed

4 files changed

+7
-2
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,7 @@ dist
107107
ksqljsTest.js
108108
package-lock.json
109109
local_ignore/
110+
.gitignore
110111

111112
# KSQLDB docker server settings
112113
ksqldb_server_config/

__tests__/integrationtests.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
const ksqljs = require('../ksqljs/ksqlJS.js');
22

33
// Pre-requisite: start a docker container
4+
/* To add to README: Prior to running test with 'npm test', please start the ksqlDB
5+
server using the command 'docker compose-up'. This will spin up a ksqlDB server on
6+
'http://localhost:8088'
7+
*/
48

59
describe('--Integration Tests--', () => {
610

docker-compose.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ services:
4343
ports:
4444
- "8088:8088"
4545
environment:
46-
KSQL_LISTENERS: https://0.0.0.0:8088
46+
KSQL_LISTENERS: http://0.0.0.0:8088
4747
KSQL_BOOTSTRAP_SERVERS: broker:9092
4848
KSQL_KSQL_LOGGING_PROCESSING_STREAM_AUTO_CREATE: "true"
4949
KSQL_KSQL_LOGGING_PROCESSING_TOPIC_AUTO_CREATE: "true"

ksqljs/ksqlJS.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ class ksqljs {
7878
this.httpsAgentHttp2 ? this.httpsAgentHttp2 : {}
7979
);
8080

81-
session.on("error", (err) => console.error(err));
81+
session.on("error", (err) => reject(err));
8282

8383
const req = session.request(
8484
this.secret && this.API ?

0 commit comments

Comments
 (0)